Fix array-lengh reference to "non-negative" from "positive" #32097
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JelleZijlstra
added
needs backport to 3.9
|
Thanks @Jongy for the PR, and @JelleZijlstra for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9, 3.10. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Mar 28, 2022
…ive" (pythonGH-32097) (cherry picked from commit 76f14b0) Co-authored-by: Yonatan Goldschmidt <yon.goldschmidt@gmail.com>
|
GH-32142 is a backport of this pull request to the 3.10 branch. |
|
GH-32143 is a backport of this pull request to the 3.9 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Mar 28, 2022
…ive" (pythonGH-32097) (cherry picked from commit 76f14b0) Co-authored-by: Yonatan Goldschmidt <yon.goldschmidt@gmail.com>
|
Thanks for your contribution! |
|
Thanks for the review @JelleZijlstra |
hello-adam
pushed a commit
to hello-adam/cpython
that referenced
this pull request
Jun 2, 2022
…ive" (pythonGH-32097) (pythonGH-32143) (cherry picked from commit 76f14b0) Co-authored-by: Yonatan Goldschmidt <yon.goldschmidt@gmail.com> Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was looking in the docs for how to create zero-length arrays, and found this reference which was misleading because you can create zero-length arrays (which serve only for taking their offsets in that case) with e.g
(c_char * 0). Onlyc_char * -1fails (as with any other negative).I suppose this is a small change so I didn't create a bpo, lmk if you think it's needed...