Skip to content

bpo-47205: Skip error check of sched_get/setaffinity on FreeBSD (GH-32285) #32285

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 3, 2022
Merged

bpo-47205: Skip error check of sched_get/setaffinity on FreeBSD (GH-32285) #32285

merged 1 commit into from
Apr 3, 2022

Conversation

tiran
Copy link
Member

@tiran tiran commented Apr 3, 2022 •
edited by bedevere-bot
Loading

@tiran tiran added tests Tests in the Lib/test dir needs backport to 3.9 only security fixes needs backport to 3.10 only security fixes labels Apr 3, 2022
@tiran tiran added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Apr 3, 2022
@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @tiran for commit a98ef05 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.

@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Apr 3, 2022
@tiran
Copy link
Member Author

tiran commented Apr 3, 2022

https://buildbot.python.org/all/#/builders/203 is now passing again \o/

Fidget-Spinner
Fidget-Spinner reviewed Apr 3, 2022
View reviewed changes
Copy link
Member

@Fidget-Spinner Fidget-Spinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM. But I'm not a FreeBSD or posix expert.

@tiran tiran changed the title bpo-47205: Skip error check of sched_get/setaffinity on FreeBSD bpo-47205: Skip error check of sched_get/setaffinity on FreeBSD (GH-32285) Apr 3, 2022
@tiran tiran merged commit b82cdd1 into python:main Apr 3, 2022
@tiran tiran deleted the bpo-47205-freebsd branch April 3, 2022 15:03
@miss-islington
Copy link
Contributor

Thanks @tiran for the PR 🌮🎉.. I'm working now to backport this PR to: 3.9, 3.10.
🐍🍒⛏🤖

@bedevere-bot
Copy link

GH-32286 is a backport of this pull request to the 3.10 branch.

@bedevere-bot
Copy link

GH-32287 is a backport of this pull request to the 3.9 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.9 only security fixes label Apr 3, 2022
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Apr 3, 2022
@tiran @miss-islington
bpo-47205: Skip error check of sched_get/setaffinity on FreeBSD (pyth…
ca67ccc 
…onGH-32285)

(cherry picked from commit b82cdd1)

Co-authored-by: Christian Heimes <christian@python.org>
miss-islington added a commit that referenced this pull request Apr 3, 2022
@miss-islington @tiran
bpo-47205: Skip error check of sched_get/setaffinity on FreeBSD (GH-3…
490ccbd 
…2285)

(cherry picked from commit b82cdd1)

Co-authored-by: Christian Heimes <christian@python.org>
miss-islington added a commit that referenced this pull request Apr 3, 2022
@miss-islington @tiran
bpo-47205: Skip error check of sched_get/setaffinity on FreeBSD (GH-3…
470dfe2 
…2285)

(cherry picked from commit b82cdd1)

Co-authored-by: Christian Heimes <christian@python.org>
hello-adam pushed a commit to hello-adam/cpython that referenced this pull request Jun 2, 2022
@miss-islington @tiran @hello-adam
bpo-47205: Skip error check of sched_get/setaffinity on FreeBSD (pyth…
21eee6b 
…onGH-32285)

(cherry picked from commit b82cdd1)

Co-authored-by: Christian Heimes <christian@python.org>
@tiran tiran mentioned this pull request Apr 21, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Fidget-Spinner Fidget-Spinner Fidget-Spinner left review comments

Assignees
No one assigned
Labels
tests Tests in the Lib/test dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@tiran @bedevere-bot @miss-islington @Fidget-Spinner @the-knights-who-say-ni