bpo-31632: (asyncio) remove local reference to app protocol in _SSLProtocolTransport #3817
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello, and thanks for your contribution! I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA). Unfortunately our records indicate you have not signed the CLA. For legal reasons we need you to sign this before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue. Thanks again to your contribution and we look forward to looking at it! |
jlacoline
changed the title
|
Looks OK. Please add a NEWS entry. |
|
News entry added |
jlacoline
force-pushed
the
fix-bpo-31632
branch
from
2b31fc1 to
a16607f
Compare
|
Thanks @jlacoline for the PR, and @1st1 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.6. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Oct 19, 2017
pythonGH-3817) (cherry picked from commit ea2ef5d)
|
GH-4052 is a backport of this pull request to the 3.6 branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an issue about the
set_protocol()method of class_SSLProtocolTransporthttps://bugs.python.org/issue31632.get_protocol()andset_protocol()methods now act on right protocol instance (i.e._ssl_protocol._app_protocol).The reference to the app protocol was removed from
_SSLProtocolTransportsince it is not used anymore (and it will reduce the risk of similar mistakes in the future).A test case was added to control the get_protocol / set_protocol feature.
https://bugs.python.org/issue31632