bpo-29704: Fix asyncio.SubprocessStreamProtocol closing #405
Conversation
|
@SethMichaelLarson, thanks for your PR! By analyzing the history of the files in this pull request, we identified @Haypo and @1st1 to be potential reviewers. |
|
@SethMichaelLarson Do we have an open issue for this on bugs.python.org? If not can you create one? |
|
We do not, I will create one now. |
|
I created an issue with @BotoX comments and links to issue on python/asyncio http://bugs.python.org/issue29704 |
1st1
changed the title
|
Please add a |
|
@1st1 Done, is that entry acceptable? |
|
Yep. Looking good now. |
|
This PR is merged, however, I didn't see that it had some trailing whitespace. Please make sure that your editor strips trailing whitespace. |
|
Note: tested this PR with all uvloop functional subprocess tests, everything looks alright. |
|
@1st1 Sorry about that! My fault for not noticing. GitHub's web editor doesn't strip whitespace like PyCharm does. :) I'm glad it also works in uvloop, I should probably test asyncio changes with uvloop as well first before submitting. |
It's not so much about uvloop as it is about some unittests there that test both uvloop & vanilla asyncio. I plan to port some of those tests to CPython to increase coverage. |
|
Anyways, thanks for the contribution! |
|
@1st1 Would be a good idea to port them, I've got some tests for selectors2 that don't occur in Python's stdlib selectors that might be considered good as well for unique situations. |
Please open a PR with those tests, selectors module is very important. For an extra benefit, you'll see your tests running on the full CPython buildbots matrix. |
|
Will do, might have to experiment with different Python versions, PEP 475 really split the behavior for anything syscall-related in Python. |
|
What is the protocol for tests that behave differently (skip?) on different Python versions? Would they only be put in the version where they should be or is it normal to have tests that only run on Python 3.5+, for example. |
|
Will do, might have to experiment with different Python versions, PEP 475
really split the behavior for anything syscall-related in Python.
I lost track of asyncio. PEP 475 was implemented in Python 3.5. Python 3.4
doesn't accept bugfixes anymore. Why do you want to test different Python
versions? Is asyncio on Python 3.3 or 3.4 still a thing?
|
|
@Haypo Ah 3.4 is off bug-fix. Makes that a lot easier! :) Disregard my above comment then. |
|
We try to keep this table up to date:
https://docs.python.org/devguide/#status-of-python-branches
|
|
@Haypo some rasberypi dev still on 3.4.2 |
|
@Haypo some rasberypi dev still on 3.4.2
https://home-assistant.io this is still on 3.4.2
I had to ship backported cookies module with aiohttp.
You are on the CPython project. There is also a
http://github.com/python/asyncio project because there is no more
release on http://pypi.python.org/pypi/asyncio/ since 2 years. I
understand that asyncio doesn't evolve anymore on Python 3.4. Upgrade
or backport yourself, no?
|
* Use GH to signify Github handle of the user instead of "@". "@" usually doesn't give any information about what exactly the handle means since we don't know it is a Github handle from the commit message. Changing the pattern to be `GH:` similar to what we do for Pull Requests with (GH-). Fixes #270 * Handle removing GH:-style Automerge-Triggered-By ...when automerge label is removed by a core-dev. Co-authored-by: Abhilash Raj <raj.abhilash1@gmail.com>
Was told by @1st1 to open this PR here from python/asyncio. See the original Pull Request for discussion and review: python/asyncio#485