bpo-31955: Correct distinguish of list and string values in set_executable() #4296
Conversation
|
Hello, and thanks for your contribution! I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA). Unfortunately we couldn't find an account corresponding to your GitHub username on bugs.python.org (b.p.o) to verify you have signed the CLA (this might be simply due to a missing "GitHub Name" entry in your b.p.o account settings). This is necessary for legal reasons before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue. Thanks again to your contribution and we look forward to looking at it! |
PavelStishenko
changed the title
|
I do not understand how to add the label "skip news". And I have signed CLA. |
PavelStishenko
changed the title
Thank you: this part is correct :-)
Since it's a bug fix, it would be better to document the bugfix in a NEWS entry, rather than skipping this part. Use the blurb tool to add a NEWS entry, see: |
There was a problem hiding this comment.
I'm not sure that we need to fix Python 3: see https://bugs.python.org/issue31955
|
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
|
Submitted new PR #4316 Closing this one because it is not needed for Python 3. |
The check "if isinstance(value, str)" is incorrect, because type of value can be unicode, while it should be splitted as well.
https://bugs.python.org/issue31955