Skip to content

bpo-26133: Fix typos #5010

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 26, 2017
Merged

bpo-26133: Fix typos #5010

merged 3 commits into from
Dec 26, 2017

Conversation

asvetlov
Copy link
Contributor

@asvetlov asvetlov commented Dec 25, 2017

f"on interpreter shutdown "
f"stage, signal unsubsription is disabled",
f"stage, signal unsubscription is disabled",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unsubscription -> skipping signal handlers removal

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed. Is now ok?

@1st1
Copy link
Member

1st1 commented Dec 25, 2017

Maybe mock sys.is_finalizing and test that branch of code?

@asvetlov asvetlov merged commit a8f4e15 into python:master Dec 26, 2017
@miss-islington
Copy link
Contributor

Thanks @asvetlov for the PR 🌮🎉.. I'm working now to backport this PR to: 3.6.
🐍🍒⛏🤖

@asvetlov asvetlov deleted the bpo-26133 branch December 26, 2017 09:53
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Dec 26, 2017
* Fix typos
* Change warning text
* Add test
(cherry picked from commit a8f4e15)
@bedevere-bot
Copy link

GH-5014 is a backport of this pull request to the 3.6 branch.

asvetlov pushed a commit that referenced this pull request Dec 26, 2017
* Fix typos
* Change warning text
* Add test
(cherry picked from commit a8f4e15)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants