bpo-32454: socket closefd #5048
Conversation
Modules/socketmodule.c
Outdated
| Py_END_ALLOW_THREADS | ||
| /* bpo-30319: The peer can already have closed the connection. | ||
| Python ignores ECONNRESET on close(). */ | ||
| if (res < 0 && errno != ECONNRESET) { |
There was a problem hiding this comment.
I think this should be !CHECK_ERRNO(ECONNRESET), or use GET_SOCK_ERROR instead of errno.
Winsock is an OS library, so it can't use errno of a particular C runtime library. It uses Windows API [WSA]GetLastError and [WSA]SetLastError.
Doc/library/socket.rst
Outdated
| Duplicate a socket file descriptor. This is like :func:`os.dup`, but for | ||
| sockets. On some platforms (most noticeable Windows) :func:`os.dup` | ||
| does not work for socket file descriptors. | ||
|
|
There was a problem hiding this comment.
You should add a versionadded too.
There was a problem hiding this comment.
The socket.dup() function exists since 2.6 at least. It just hasn't been documented yet.
| @@ -1519,6 +1519,24 @@ def test_unusable_closed_socketio(self): | |||
| self.assertRaises(ValueError, fp.writable) | |||
| self.assertRaises(ValueError, fp.seekable) | |||
|
|
|||
| def test_socket_close(self): | |||
There was a problem hiding this comment.
Is there already a test for dup()?
There was a problem hiding this comment.
No, there is no test. I don't have time to write a test case, Would you like me to drop the documentation for dup?
Lib/test/test_socket.py
Outdated
| try: | ||
| sock.close() | ||
| except OSError: | ||
| # sock.close() fails with EBADF |
There was a problem hiding this comment.
If it always does, then how about a assertRaises?
There was a problem hiding this comment.
assertRaises in the finally block may mask an error in the try block.
There was a problem hiding this comment.
Normally, Python 3 would display the exception chain.
Add close(fd) function to the socket module Signed-off-by: Christian Heimes <christian@python.org>
|
I removed the documentation for |
|
@tiran: Please replace |
|
thx @pitrou |
Add close(fd) function to the socket module
Signed-off-by: Christian Heimes christian@python.org
NOTE The PR also documents the previously undocumented
socket.closefunction.https://bugs.python.org/issue32454