bpo-32593: Drop FreeBSD 9 and older support #5232
Conversation
Drop support of FreeBSD 9 and older.
|
Hum, the change should be mentionned in Doc/whatsnew/3.7.rst. |
Lib/distutils/unixccompiler.py
Outdated
| @@ -227,7 +227,7 @@ def runtime_library_dir_option(self, dir): | |||
| if sys.platform[:6] == "darwin": | |||
| # MacOSX's linker doesn't understand the -R flag at all | |||
| return "-L" + dir | |||
| elif sys.platform[:7] == "freebsd": | |||
| elif sys.platform.startswith("freebsd"): | |||
There was a problem hiding this comment.
I do not see why FreeBSD has a special treatment it should work the same as linux here
There was a problem hiding this comment.
I'm sorry, I don't know this code and I never understood what is rpath. If you consider that the code is outdated/can be simplified, would you mind to open a new issue? Maybe even write a PR to implement your proposed change?
There was a problem hiding this comment.
It is simple the only thing needed it dropping the block and let it fall into the else like linux
There was a problem hiding this comment.
I created #5233 : would you mind to review it and test it?
There was a problem hiding this comment.
I reverted this change and wrote PR #5233 instead.
|
as a principle it is fine to drop support to non supported version of FreeBSD in your next major version |
Done. |
Drop support of FreeBSD 9 and older.
https://bugs.python.org/issue32593