bpo-32731: Specify Exception type of getpass.getuser #5616
Conversation
|
Hello, and thanks for your contribution! I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA). Unfortunately our records indicate you have not signed the CLA. For legal reasons we need you to sign this before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue. We also demand... A SHRUBBERY! Thanks again to your contribution and we look forward to looking at it! |
| @@ -0,0 +1 @@ | |||
| Improve documentation of exception raised in :func:`getpass.getuser()` | |||
There was a problem hiding this comment.
| Improve documentation of exception raised in :func:`getpass.getuser()` | |
| Improve documentation of exceptions raised in :func:`getpass.getuser()`. |
| If none are set, the function attempts to retrieve the login name from the | ||
| password database. On systems which the :mod:`pwd` module is not supported, | ||
| an :exc:`ImportError` is raised. If no login name is found, an | ||
| :exc:`KeyError` is raised :func:`pwd.getpwuid`. |
There was a problem hiding this comment.
What is the mention for pwd.getwuid() for? Is it to state that it's the function that causes KeyError to be raised?
And are there tests that these exception are raised in these scenarios?
|
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
https://bugs.python.org/issue32731