bpo-24132: refactor pathlib to allow easy subclassing #6248
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello, and thanks for your contribution! I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA). Unfortunately our records indicate you have not signed the CLA. For legal reasons we need you to sign this before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue. Thanks again to your contribution and we look forward to looking at it! |
`PurePath` and `Path` are now just variables pointing at the corresponding classes (resp. PurePosixPath or PureWindowsPath, and PosixPath or WindowsPath) depending on the platform running the code.
|
Thanks for the PR, but closing as the CLA has not been signed within the last month. If you do decide to sign the CLA we can re-open this PR. |
gst
reviewed
Mar 26, 2021
| class _PathParents(Sequence): | ||
| """This object provides sesquence-like access to the logical ancestors | ||
| of a path. Don't try to construt it yourself.""" | ||
| ___slots__ = ('pathcls', '_drv', '_root', '_parts') |
There was a problem hiding this comment.
probably a typo but you have 3 leading _ ..
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PurePathandPathare now just variables pointing at thecorresponding classes (resp. PurePosixPath or PureWindowsPath, and
PosixPath or WindowsPath) depending on the platform running the code.
https://bugs.python.org/issue24132