Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-33222: Add canonicalisation to paths in site test suite. #6434

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

bpo-33222: Add canonicalisation to paths in site test suite. #6434

wants to merge 2 commits into from
+4 −2

Conversation

akshaysharma096
Copy link
Contributor

@akshaysharma096 akshaysharma096 commented Apr 9, 2018 •
edited by bedevere-bot
Loading

@the-knights-who-say-ni
Copy link

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA).

Unfortunately our records indicate you have not signed the CLA. For legal reasons we need you to sign this before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

Thanks again to your contribution and we look forward to looking at it!

jdemeyer
jdemeyer requested changes Feb 5, 2019
View reviewed changes
Copy link
Contributor

@jdemeyer jdemeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is also a failing test in test_sysconfig

Misc/NEWS.d/next/Tests/2018-04-09-22-49-40.bpo-33222.dWWouj.rst
@@ -0,0 +1 @@
Add canonicalization to paths in site test suite.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure that we need a NEWS entry just for fixing the testsuite.

@jdemeyer jdemeyer mentioned this pull request Jun 16, 2022
Closed
@github-actions
Copy link

This PR is stale because it has been open for 30 days with no activity.

@github-actions github-actions bot added the stale Stale PR or inactive for long period of time. label Aug 16, 2022
iritkatriel
iritkatriel requested changes Dec 7, 2022
View reviewed changes
Copy link
Member

@iritkatriel iritkatriel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This has merge conflicts now.

@bedevere-bot
Copy link

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@github-actions github-actions bot removed the stale Stale PR or inactive for long period of time. label May 15, 2023
@github-actions GitHub Actions
Copy link

This PR is stale because it has been open for 30 days with no activity.

@github-actions github-actions bot added the stale Stale PR or inactive for long period of time. label Sep 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdemeyer jdemeyer jdemeyer requested changes

@iritkatriel iritkatriel iritkatriel requested changes

Assignees
No one assigned
Labels
awaiting changes stale Stale PR or inactive for long period of time.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@akshaysharma096 @the-knights-who-say-ni @bedevere-bot @iritkatriel @jdemeyer @ned-deily @ezio-melotti