Skip to content

bpo-34093: Stablize FLAG_REF usage (two-pass version) #8293

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

bpo-34093: Stablize FLAG_REF usage (two-pass version) #8293

wants to merge 2 commits into from

Conversation

@methane
Copy link
Member

@methane methane commented Jul 16, 2018 •
edited by bedevere-bot
Loading

methane added 2 commits July 10, 2018 22:19
@methane
Make marshal stable
e170116 
marshal used refcnt() to decide use FLAG_REF or not.

Even when one object is used only once in marshled object,
FLAG_REF could be used.

This commit makes marshal two-pass.  It counts refs
at first pass.  In second pass, mashal objects and
use FLAG_REF only when the object is used more than twice.
@methane
Make *stable* optional
9d7e8f1
@methane methane requested a review from serhiy-storchaka July 16, 2018 07:28
@methane
Copy link
Member Author

methane commented Jul 16, 2018

I don't like the option name stable, because it is very unclear what is stable.
It just helps reproducible pyc build.

@ericsnowcurrently
Copy link
Member

ericsnowcurrently commented Sep 16, 2021

Wow, this is very similar to a PR I made for the same problem (before you pointed me here): gh-28379. The biggest difference is that I literally call w_object() twice, where the first pass determines how many times an object is used (and the result bytes are discarded).

@ericsnowcurrently ericsnowcurrently mentioned this pull request Sep 16, 2021
Closed
@methane methane mentioned this pull request May 2, 2022
Closed
@methane methane closed this May 4, 2022
@methane methane deleted the stable-marshal-1 branch May 4, 2022 01:08
@methane methane mentioned this pull request Apr 10, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@serhiy-storchaka serhiy-storchaka Awaiting requested review from serhiy-storchaka

Assignees

No one assigned

Labels

awaiting merge DO-NOT-MERGE

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@methane @ericsnowcurrently @the-knights-who-say-ni @bedevere-bot