Skip to content

gh-79846: Make ssl.create_default_context() ignore invalid certificates #91740

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Aug 7, 2024
Merged

gh-79846: Make ssl.create_default_context() ignore invalid certificates #91740

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
d2770a2
[ssl] Load CA certificates one by one
pukkandan Apr 20, 2022
3411826
Add NEWS entry
pukkandan Apr 20, 2022
1275d5d
Merge branch 'main' into bugs/79846
pukkandan Jul 2, 2022
45dc30f
Merge branch 'main' into bugs/79846
serhiy-storchaka Feb 21, 2024
94c8ec1
Merge branch 'main' into bugs/79846
serhiy-storchaka Jul 29, 2024
9d31e3a
Load only certificates that have correct encoding and purpose.
serhiy-storchaka Jul 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions Lib/ssl.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -513,18 +513,17 @@ def set_alpn_protocols(self, alpn_protocols):
self._set_alpn_protocols(protos)

def _load_windows_store_certs(self, storename, purpose):
certs = bytearray()
try:
for cert, encoding, trust in enum_certificates(storename):
# CA certs are never PKCS#7 encoded
if encoding == "x509_asn":
if trust is True or purpose.oid in trust:
certs.extend(cert)
try:
self.load_verify_locations(cadata=cert)
except SSLError as exc:
warnings.warn(f"Bad certificate in Windows certificate store: {exc!s}")
except PermissionError:
warnings.warn("unable to enumerate Windows certificate store")
if certs:
self.load_verify_locations(cadata=certs)
return certs

def load_default_certs(self, purpose=Purpose.SERVER_AUTH):
if not isinstance(purpose, _ASN1Object):
Expand Down
2 changes: 2 additions & 0 deletions Misc/NEWS.d/next/Windows/2022-04-20-18-32-30.gh-issue-79846.Vggv3f.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
Makes :code:`ssl.create_default_context()` ignore invalid certificates in
the Windows certificate store
Loading