Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-91860: Add typing.dataclass_transform (PEP 681) #91861

Merged
merged 3 commits into from
Apr 26, 2022
Merged

gh-91860: Add typing.dataclass_transform (PEP 681) #91861

merged 3 commits into from
Apr 26, 2022
+167 −0

Conversation

JelleZijlstra
Copy link
Member

@JelleZijlstra JelleZijlstra commented Apr 23, 2022 •
edited
Loading

Copied from typing-extensions (python/typing#1054, python/typing#1120).

Documentation is intentionally omitted, so we can focus on getting the
runtime part in before the feature freeze.

#91860

@JelleZijlstra
pythongh-91860: Add typing.dataclass_transform (PEP 681)
9a5bcc3 
Copied from typing-extensions (python/typing#1054, python/typing#1120).

Documentation is intentionally omitted, so we can focus on getting the
runtime part in before the feature freeze.
Fidget-Spinner
Fidget-Spinner reviewed Apr 23, 2022
View reviewed changes
Copy link
Member

@Fidget-Spinner Fidget-Spinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow. I just read the PEP and this implementation for the first time. So I'll have some newbie concerns.

AlexWaygood
AlexWaygood reviewed Apr 24, 2022
View reviewed changes
Copy link
Member

@AlexWaygood AlexWaygood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Implementation and tests look good, just a few comments on the docstring

@JelleZijlstra
Copy link
Member Author

Thanks @Fidget-Spinner and @AlexWaygood for the feedback, I just pushed some changes.

AlexWaygood
AlexWaygood approved these changes Apr 24, 2022
View reviewed changes
Copy link
Member

@AlexWaygood AlexWaygood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! :)

AlexWaygood
AlexWaygood reviewed Apr 24, 2022
View reviewed changes
@JelleZijlstra
the other examples don't need a TypeVar

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
5825373
@AlexWaygood AlexWaygood added type-feature A feature request or enhancement topic-typing stdlib Python modules in the Lib dir labels Apr 25, 2022
@JelleZijlstra JelleZijlstra merged commit 5397b5a into python:main Apr 26, 2022
@JelleZijlstra JelleZijlstra deleted the pep681 branch April 26, 2022 03:30
@JelleZijlstra JelleZijlstra mentioned this pull request Apr 26, 2022
Merged
JelleZijlstra added a commit to JelleZijlstra/typeshed that referenced this pull request Apr 26, 2022
@JelleZijlstra
typing: Add dataclass_transform
edd2a60 
python/cpython#91861
AlexWaygood pushed a commit to python/typeshed that referenced this pull request Apr 26, 2022
@JelleZijlstra
typing: Add dataclass_transform (#7690)
c8a978f 
python/cpython#91861
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Fidget-Spinner Fidget-Spinner

@AlexWaygood AlexWaygood

@gvanrossum gvanrossum

Assignees
No one assigned
Labels
stdlib Python modules in the Lib dir topic-typing type-feature A feature request or enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@JelleZijlstra @Fidget-Spinner @AlexWaygood @bedevere-bot