-
-
Notifications
You must be signed in to change notification settings - Fork 32.2k
gh-59648: Nanosecond support for datetime #92078
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
SmartManoj
wants to merge
163
commits into
python:main
Choose a base branch
from
SmartManoj:patch-4
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Every change to Python requires a NEWS entry. Please, add it using the blurb_it Web app or the blurb command-line tool. |
MojoVampire
requested changes
May 3, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary:
- Don't apply automatic style fixes; it bloats the patch and makes it much harder to review
- Using
Decimal
the way you're using it is inherently unsafe due to unknown contextual precision, and will make the code slower to boot. Find a way to do your work withint
when usingfloat
becomes impossible. Bonus: It won't make importingdatetime
force you to loadDecimal
in the process (a relatively heavyweight module) - Several comparison and hash functions aren't using the submicrosecond data, so the extra data gets ignored, which seems like a problem.
- You broke pickling. Please don't do that.
- (A biggy I couldn't comment on inline) This only changes the Python level
datetime
module, that CPython itself doesn't even use, by and large. Any change to the Python level code indatetime.py
requires a complementary change in_datetimemodule.c
so the C accelerated version of the module has the same behavior (you may have avoided at least a few test failures because they were testing the C module and didn't notice the broken code in the Python module)
This API looks reasonable to me. @tim-one What do you think? |
FichteFoll
reviewed
Jan 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds nanosecond as a keyword argument for backward compatibility
Solves: #59648