Skip to content

[3.10] gh-80254: Disallow recursive usage of cursors in sqlite3 converters #92274

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

erlend-aasland
Copy link
Contributor

@erlend-aasland erlend-aasland commented May 3, 2022

(cherry picked from commit f629dcf)

Co-authored-by: Sergey Fedoseev fedoseev.sergey@gmail.com
Co-authored-by: Jelle Zijlstra jelle.zijlstra@gmail.com

…3` converters (python#29054)

(cherry picked from commit f629dcf)

Co-authored-by: Sergey Fedoseev <fedoseev.sergey@gmail.com>
Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
@JelleZijlstra JelleZijlstra self-assigned this May 3, 2022
@JelleZijlstra JelleZijlstra added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label May 3, 2022
@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @JelleZijlstra for commit c908dc5 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.

@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label May 3, 2022
@JelleZijlstra
Copy link
Member

The buildbots found some refleaks:

test_sqlite leaked [3, 3, 3] references, sum=9
test_sqlite leaked [2, 2, 2] memory blocks, sum=6

@erlend-aasland
Copy link
Contributor Author

It's the same in the 3.9 backport. I'll look into it.

@erlend-aasland erlend-aasland added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label May 5, 2022
@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @erlend-aasland for commit 68aac73 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.

@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label May 5, 2022
@JelleZijlstra JelleZijlstra merged commit 2a2421e into python:3.10 May 5, 2022
@erlend-aasland erlend-aasland deleted the backport-sqlite-converter-segfault-3.10 branch May 5, 2022 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants