gh-87390: Fix starred tuple equality and pickling (alt) #92337
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
serhiy-storchaka
added
type-bug
| @@ -394,6 +396,7 @@ def test_pickle(self): | |||
| self.assertEqual(loaded.__origin__, alias.__origin__) | |||
| self.assertEqual(loaded.__args__, alias.__args__) | |||
| self.assertEqual(loaded.__parameters__, alias.__parameters__) | |||
| self.assertEqual(type(loaded), type(alias)) | |||
There was a problem hiding this comment.
It is the same for types. And I do not want to restart the CI testing for such minor change. 😉
|
LGTM. But IMO this needs a news, and like Jelle mentioned more tests (maybe we can take the ones from Mathew's PR and credit him?) |
|
The old tests already cover pickling. They were passed, because equality was broken in the same way as pickling. I fixed equality in #92335, but it made pickling tests failing. Since it fixes not yet released code, there is no sense in adding a NEWS entry. It can only confuse readers. |
|
Additional tests in Mathew's PR are for the third parameter of GenericAlias. That change is not included in this PR. |
|
Thanks Serhiy! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is a simpler alternative of #92249.
#87390