-
-
Notifications
You must be signed in to change notification settings - Fork 31.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gh-76773: Update docs mentioning no-longer-supported Windows versions & features #92529
gh-76773: Update docs mentioning no-longer-supported Windows versions & features #92529
Conversation
Doc/using/windows.rst
Outdated
command: | ||
|
||
:: | ||
|
||
py -2 | ||
py -3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks superfluous. Just py
starts the latest Python version, and currently it is the latest Python 3 version.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point, thanks. Would you like me to revert the change to keep py -2
, or elide the whole mention as superflous?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As long as there is an example of using py
you can leave it as it's a feature that is still supported.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I interpret it as you can leave py -2
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, thanks. I reverted it to that, and also cleaned up the reST code block syntax on or near the lines I touched.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No objections, but not ready to merge yet
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Not sure if anyone else is reviewing, so I won't merge immediately
Doc/using/windows.rst
Outdated
command: | ||
|
||
:: | ||
|
||
py -2 | ||
py -3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As long as there is an example of using py
you can leave it as it's a feature that is still supported.
Thanks @CAM-Gerlach for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9, 3.10, 3.11. |
GH-92608 is a backport of this pull request to the 3.11 branch. |
GH-92609 is a backport of this pull request to the 3.10 branch. |
GH-92610 is a backport of this pull request to the 3.9 branch. |
…rsions & features (pythonGH-92529) (cherry picked from commit f1bbcba) Co-authored-by: CAM Gerlach <CAM.Gerlach@Gerlach.CAM>
…rsions & features (pythonGH-92529) (cherry picked from commit f1bbcba) Co-authored-by: CAM Gerlach <CAM.Gerlach@Gerlach.CAM>
…rsions & features (pythonGH-92529) (cherry picked from commit f1bbcba) Co-authored-by: CAM Gerlach <CAM.Gerlach@Gerlach.CAM>
…ows versions & features (pythonGH-92529) (pythonGH-92610) (cherry picked from commit f1bbcba) Co-authored-by: CAM Gerlach <CAM.Gerlach@Gerlach.CAM> Automerge-Triggered-By: GH:serhiy-storchaka
In #76773 , I compiled a detailed list of places where currently or (then-)to-be-unsupported Windows versions were referred to in the context of being current, with a focus on documentation. Unfortunately, as the issue became mired for a time in debates about whether and when it was necessary to drop Windows <8.1 support, I was never able to follow up and update them.
Support for Windows <8.1 was broken in PR #18231 to fix issue #83582 (CVE-2020-8315), dropped officially (albeit rather unceremoniously, with only a short news entry and without documentation updates) in @zooba 's PR #21656 to resolve issue #85584 and clarified a bit at least in the "Using Python on Windows" document in PR #23603 addressing issue #42523 . However, it appears that besides that, few of the others enumerated there were actually updated.
Therefore, this PR updates them, as well as a handful of other mentions I found in the process. In particular, it:
All of the changes should be backport-safe since the removed/updated portions are mostly long-obsolete and support for Windows <8.1 was dropped in Python 3.9, the earliest version still accepting bugfix PRs; I avoided any changes that were potentially version-specific or referred to anything 3.9 or later.