Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-92412: Clarifying the documentation on library/syslog #92587

Merged
merged 1 commit into from
Jul 26, 2022
Merged

gh-92412: Clarifying the documentation on library/syslog #92587

merged 1 commit into from
Jul 26, 2022

Conversation

Gaasmann
Copy link
Contributor

@Gaasmann Gaasmann commented May 9, 2022

Clarifying the "Changed in version 3.2" paragraph for syslog.openlog as
the wording could confuse people about ident being a mandatory argument
with a default value.

@cpython-cla-bot
Copy link

cpython-cla-bot bot commented May 9, 2022 •
edited
Loading

All commit authors signed the Contributor License Agreement.
CLA signed

@bedevere-bot
Copy link

Every change to Python requires a NEWS entry.

Please, add it using the blurb_it Web app or the blurb command-line tool.

@bedevere-bot bedevere-bot added docs Documentation in the Doc dir awaiting review labels May 9, 2022
@bedevere-bot
Copy link

Every change to Python requires a NEWS entry.

Please, add it using the blurb_it Web app or the blurb command-line tool.

@Gaasmann
Clarifying the documentation on library/syslog
d05dcdf 
Clarifying the "Changed in version 3.2" paragraph for syslog.openlog as
the wording could confuse people about *ident* being a mandatory argument
with a default value.
@Gaasmann Gaasmann changed the title gh-92412: Clarifying the documentaion on library/syslog gh-92412: Clarifying the documentation on library/syslog May 9, 2022
@Gaasmann
Copy link
Contributor Author

Gaasmann commented May 9, 2022

@rhettinger Thank you for approving my first pull request :-)

@Gaasmann
Copy link
Contributor Author

Hello @rhettinger, the PR is ready to be merged. Let me know if there is anything I need to do, this is pretty new to me :-)

@Gaasmann
Copy link
Contributor Author

#92412

@kumaraditya303 kumaraditya303 added needs backport to 3.10 only security fixes needs backport to 3.11 only security fixes labels Jul 22, 2022
@rhettinger rhettinger merged commit b7ce462 into python:main Jul 26, 2022
@miss-islington
Copy link
Contributor

Thanks @Gaasmann for the PR, and @rhettinger for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Sorry @Gaasmann and @rhettinger, I had trouble checking out the 3.11 backport branch.
Please backport using cherry_picker on command line.
cherry_picker b7ce4625fe2a8a4d6c1db6b39b52c7f97d384caa 3.11

@bedevere-bot
Copy link

GH-95266 is a backport of this pull request to the 3.10 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.10 only security fixes label Jul 26, 2022
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 26, 2022
@Gaasmann @miss-islington
Clarifying the documentation on library/syslog (pythonGH-92587)
4030a30 
(cherry picked from commit b7ce462)

Co-authored-by: Nicolas Haller <nicolas@haller.im>
hauntsaninja pushed a commit to hauntsaninja/cpython that referenced this pull request Jul 31, 2022
@Gaasmann @hauntsaninja
[3.11] Clarifying the documentation on library/syslog (pythonGH-92587)
ba39db3 
(cherry picked from commit b7ce462)

Co-authored-by: Nicolas Haller <nicolas@haller.im>
@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Jul 31, 2022
@bedevere-bot
Copy link

GH-95492 is a backport of this pull request to the 3.11 branch.

ambv pushed a commit that referenced this pull request Aug 5, 2022
@hauntsaninja @Gaasmann
[3.11] Clarifying the documentation on library/syslog (GH-92587) (GH-…
6a36b8e 
…95492)

(cherry picked from commit b7ce462)

Co-authored-by: Nicolas Haller <nicolas@haller.im>
ambv pushed a commit that referenced this pull request Aug 12, 2022
@miss-islington @Gaasmann
gh-92412: Clarify the documentation on library/syslog (GH-92587) (GH-…
e21574a 
…95266)

(cherry picked from commit b7ce462)

Co-authored-by: Nicolas Haller <nicolas@haller.im>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rhettinger rhettinger rhettinger approved these changes

Assignees

@rhettinger rhettinger

Labels
docs Documentation in the Doc dir skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Gaasmann @bedevere-bot @miss-islington @rhettinger @kumaraditya303