Skip to content

[3.10] gh-92311: Let frame_setlineno jump over listcomps #92717

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
May 12, 2022
Merged

[3.10] gh-92311: Let frame_setlineno jump over listcomps #92717

merged 5 commits into from
May 12, 2022

Conversation

sweeneyde
Copy link
Member

No description provided.

@sweeneyde sweeneyde requested a review from markshannon as a code owner May 12, 2022 09:34
@sweeneyde sweeneyde added the needs backport to 3.9 only security fixes label May 12, 2022
markshannon
markshannon requested changes May 12, 2022
View reviewed changes
Copy link
Member

@markshannon markshannon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few nits, but otherwise looks good.
Thanks for fixing this.

@bedevere-bot
Copy link

When you're done making the requested changes, leave the comment: I have made the requested changes; please review again.

@sweeneyde
Copy link
Member Author

I have made the requested changes; please review again

@bedevere-bot
Copy link

Thanks for making the requested changes!

@markshannon: please review the changes made to this pull request.

@bedevere-bot bedevere-bot requested a review from markshannon May 12, 2022 10:30
@markshannon
Copy link
Member

Thanks.

@markshannon markshannon merged commit a24e676 into python:3.10 May 12, 2022
@miss-islington
Copy link
Contributor

Thanks @sweeneyde for the PR, and @markshannon for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Sorry @sweeneyde and @markshannon, I had trouble checking out the 3.9 backport branch.
Please backport using cherry_picker on command line.
cherry_picker a24e67697362e76dd25d6901109277458b5971b9 3.9

@sweeneyde sweeneyde mentioned this pull request May 14, 2022
Closed
@sweeneyde sweeneyde deleted the setlineno_comprehension branch June 11, 2022 01:47
@ZeroIntensity ZeroIntensity removed the needs backport to 3.9 only security fixes label Feb 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markshannon markshannon Awaiting requested review from markshannon markshannon is a code owner

Assignees

@markshannon markshannon

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@sweeneyde @bedevere-bot @markshannon @miss-islington @ZeroIntensity