Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-92780: Improve sqlite3.Connection.create_collation docs #92790

Merged
merged 3 commits into from
May 18, 2022
Merged

gh-92780: Improve sqlite3.Connection.create_collation docs #92790

merged 3 commits into from
May 18, 2022

Conversation

erlend-aasland
Copy link
Contributor

@erlend-aasland erlend-aasland commented May 13, 2022 •
edited
Loading

Resolves #92780

@bedevere-bot bedevere-bot added docs Documentation in the Doc dir awaiting core review labels May 13, 2022
@erlend-aasland erlend-aasland added skip news needs backport to 3.9 only security fixes needs backport to 3.10 only security fixes needs backport to 3.11 only security fixes labels May 13, 2022
@erlend-aasland
Copy link
Contributor Author

@AdrianIssott, would you mind reviewing this?

AlexWaygood
AlexWaygood approved these changes May 15, 2022
View reviewed changes
Copy link
Member

@AlexWaygood AlexWaygood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, other than the mishap with ReST :)

@AlexWaygood
Update Doc/library/sqlite3.rst
8d788da 
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
@AdrianIssott
Copy link

LGTM 👍

@erlend-aasland
Copy link
Contributor Author

Thanks for the reviews. I'll merge in a day or two.

@erlend-aasland erlend-aasland merged commit 7ee19e2 into python:main May 18, 2022
@miss-islington
Copy link
Contributor

Thanks @erlend-aasland for the PR 🌮🎉.. I'm working now to backport this PR to: 3.9, 3.10, 3.11.
🐍🍒⛏🤖

@erlend-aasland erlend-aasland deleted the sqlite-collation-docs branch May 18, 2022 11:44
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 18, 2022
@erlend-aasland @miss-islington
pythongh-92780: Improve sqlite3.Connection.create_collation docs (pyt…
ba8993f 
…honGH-92790)

Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
(cherry picked from commit 7ee19e2)

Co-authored-by: Erlend Egeberg Aasland <erlend.aasland@protonmail.com>
@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label May 18, 2022
@bedevere-bot
Copy link

GH-92922 is a backport of this pull request to the 3.11 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 18, 2022
@erlend-aasland @miss-islington
pythongh-92780: Improve sqlite3.Connection.create_collation docs (pyt…
b9bc99d 
…honGH-92790)

Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
(cherry picked from commit 7ee19e2)

Co-authored-by: Erlend Egeberg Aasland <erlend.aasland@protonmail.com>
@bedevere-bot bedevere-bot removed the needs backport to 3.10 only security fixes label May 18, 2022
@bedevere-bot
Copy link

GH-92923 is a backport of this pull request to the 3.10 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 18, 2022
@erlend-aasland @miss-islington
pythongh-92780: Improve sqlite3.Connection.create_collation docs (pyt…
a695ae6 
…honGH-92790)

Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
(cherry picked from commit 7ee19e2)

Co-authored-by: Erlend Egeberg Aasland <erlend.aasland@protonmail.com>
@bedevere-bot
Copy link

GH-92924 is a backport of this pull request to the 3.9 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.9 only security fixes label May 18, 2022
@erlend-aasland erlend-aasland mentioned this pull request May 18, 2022
Closed
miss-islington added a commit that referenced this pull request May 18, 2022
@miss-islington @erlend-aasland
gh-92780: Improve sqlite3.Connection.create_collation docs (GH-92790)
65ebd92 
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
(cherry picked from commit 7ee19e2)

Co-authored-by: Erlend Egeberg Aasland <erlend.aasland@protonmail.com>
miss-islington added a commit that referenced this pull request May 18, 2022
@miss-islington @erlend-aasland
gh-92780: Improve sqlite3.Connection.create_collation docs (GH-92790)
94e21cf 
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
(cherry picked from commit 7ee19e2)

Co-authored-by: Erlend Egeberg Aasland <erlend.aasland@protonmail.com>
@erlend-aasland erlend-aasland mentioned this pull request Apr 24, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexWaygood AlexWaygood AlexWaygood approved these changes

@berkerpeksag berkerpeksag Awaiting requested review from berkerpeksag berkerpeksag is a code owner

Assignees
No one assigned
Labels
docs Documentation in the Doc dir skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

sqlite3: Connection.create_collation() documentation inaccuracies
5 participants
@erlend-aasland @AdrianIssott @miss-islington @bedevere-bot @AlexWaygood