-
-
Notifications
You must be signed in to change notification settings - Fork 31.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gh-93183: Adjust wording in socket docs #92935
Conversation
Replace "package" and "packages" with "packet" and "packets" in comments in sample code.
The following commit authors need to sign the Contributor License Agreement: |
Most changes to Python require a NEWS entry. Please add it using the blurb_it web app or the blurb command-line tool. |
@VictorNorman, please sign the CLA. |
Quoting https://devguide.python.org/committing/#assessing-a-pull-request:
AFAICS, this PR can land without the CLA being signed. |
Darn, that does not help; I'm unable to merge since the CI does not pass. So, @VictorNorman, please sign the CLA, or I cannot merge this. |
This seems to be a regression with the new CLA system - was it intended? @VictorNorman has an institutional email address, so may need to go through the corporate signing process with his university, rather than the individual process. A |
I'm not sure what to do with this PR. Should we just close it? As long as Victor Norman does not respond, there is not much I can do, at least. |
@erlend-aasland it isn't a copyrightable change, so I would close and you could just push the changes & backport as a core dev (I would open a PR myself but I'm plagued by CLA issues!) A |
Ok, thanks, I'll do that tomorrow. |
Replace "package" and "packages" with "packet" and "packets" in comments in sample code.