Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-93183: Adjust wording in socket docs #92935

Closed
wants to merge 4 commits into from

Conversation

VictorNorman
Copy link

Replace "package" and "packages" with "packet" and "packets" in comments in sample code.

Replace "package" and "packages" with "packet" and "packets" in comments in sample code.
@cpython-cla-bot
Copy link

cpython-cla-bot bot commented May 18, 2022

The following commit authors need to sign the Contributor License Agreement:

Click the button to sign:
CLA not signed

@bedevere-bot
Copy link

Most changes to Python require a NEWS entry.

Please add it using the blurb_it web app or the blurb command-line tool.

@bedevere-bot bedevere-bot added docs Documentation in the Doc dir awaiting review labels May 18, 2022
@erlend-aasland erlend-aasland changed the title Update socket.rst Doc: adjust wording in socket docs May 19, 2022
@erlend-aasland
Copy link
Contributor

@VictorNorman, please sign the CLA.

@erlend-aasland
Copy link
Contributor

@VictorNorman, please sign the CLA.

Quoting https://devguide.python.org/committing/#assessing-a-pull-request:

Make sure that the contributor has signed a Contributor Licensing Agreement (CLA), unless their change has no possible intellectual property associated with it (e.g. fixing a spelling mistake in documentation)

AFAICS, this PR can land without the CLA being signed.

@erlend-aasland
Copy link
Contributor

Quoting https://devguide.python.org/committing/#assessing-a-pull-request:

Make sure that the contributor has signed a Contributor Licensing Agreement (CLA), unless their change has no possible intellectual property associated with it (e.g. fixing a spelling mistake in documentation)

AFAICS, this PR can land without the CLA being signed.

Darn, that does not help; I'm unable to merge since the CI does not pass. So, @VictorNorman, please sign the CLA, or I cannot merge this.

@erlend-aasland erlend-aasland added the pending The issue will be closed if no feedback is provided label May 20, 2022
@erlend-aasland erlend-aasland linked an issue May 24, 2022 that may be closed by this pull request
@erlend-aasland erlend-aasland changed the title Doc: adjust wording in socket docs gh-93183: Adjust wording in socket docs May 24, 2022
@AA-Turner
Copy link
Member

I'm unable to merge since the CI does not pass

This seems to be a regression with the new CLA system - was it intended? @VictorNorman has an institutional email address, so may need to go through the corporate signing process with his university, rather than the individual process.

A

@AA-Turner AA-Turner added needs backport to 3.10 only security fixes needs backport to 3.11 only security fixes labels May 26, 2022
@erlend-aasland
Copy link
Contributor

I'm not sure what to do with this PR. Should we just close it? As long as Victor Norman does not respond, there is not much I can do, at least.

@AA-Turner
Copy link
Member

AA-Turner commented Jun 14, 2022

@erlend-aasland it isn't a copyrightable change, so I would close and you could just push the changes & backport as a core dev (I would open a PR myself but I'm plagued by CLA issues!)

A

@erlend-aasland
Copy link
Contributor

Ok, thanks, I'll do that tomorrow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting merge docs Documentation in the Doc dir needs backport to 3.10 only security fixes needs backport to 3.11 only security fixes pending The issue will be closed if no feedback is provided skip news
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[docs] socket documentation: "packages" -> "packets"
7 participants