Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-91985: Ensure consistency when getpath re-initializes sys.path with PYTHONHOME #93075

Closed
wants to merge 1 commit into from
Closed

Conversation

neonene
Copy link
Contributor

@neonene neonene commented May 22, 2022

@neonene
Copy link
Contributor Author

neonene commented May 22, 2022

@zooba Could you please review the patch?

@erlend-aasland erlend-aasland requested a review from zooba May 22, 2022 22:02
Copy link
Member

@zooba zooba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand the issue yet, but this script is supposed to initialize config['home'], so the patch is definitely wrong.

@bedevere-bot
Copy link

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@neonene neonene closed this May 23, 2022
@neonene neonene deleted the getsyspath branch May 23, 2022 18:24
@neonene
Copy link
Contributor Author

neonene commented May 23, 2022

Thanks for the review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants