Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-90016: Reword sqlite3 adapter/converter docs #93095

Merged
merged 34 commits into from
Jun 25, 2022
Merged

gh-90016: Reword sqlite3 adapter/converter docs #93095

merged 34 commits into from
Jun 25, 2022

Commits on May 23, 2022

  1. pythongh-90016: Reword sqlite3 adapter/converter docs

    @erlend-aasland
    erlend-aasland committed May 23, 2022
    Configuration menu
    Copy the full SHA
    598e26a View commit details
    Browse the repository at this point in the history

  2. Add current adapters/converter as recipes: improve this

    @erlend-aasland
    erlend-aasland committed May 23, 2022
    Configuration menu
    Copy the full SHA
    e5b1b88 View commit details
    Browse the repository at this point in the history

  3. default role

    @erlend-aasland
    erlend-aasland committed May 23, 2022
    Configuration menu
    Copy the full SHA
    9399b54 View commit details
    Browse the repository at this point in the history

  4. Formatting

    @erlend-aasland
    erlend-aasland committed May 23, 2022
    Configuration menu
    Copy the full SHA
    40bb59a View commit details
    Browse the repository at this point in the history

  5. Address Serhiy's review 

    - revert most argument spec changes
- align argument spec across docstrings/docs
- improve wording of register_adapter/register_converter
- undo note
    @erlend-aasland
    erlend-aasland committed May 23, 2022
    Configuration menu
    Copy the full SHA
    82cf3e2 View commit details
    Browse the repository at this point in the history

Commits on May 25, 2022

  1. Address Alex' review

    @erlend-aasland
    erlend-aasland committed May 25, 2022
    Configuration menu
    Copy the full SHA
    0b6f381 View commit details
    Browse the repository at this point in the history

  2. Nit

    @erlend-aasland
    erlend-aasland committed May 25, 2022
    Configuration menu
    Copy the full SHA
    c4dde48 View commit details
    Browse the repository at this point in the history

  3. Address Alex' nitpicks

    @erlend-aasland
    erlend-aasland committed May 25, 2022
    Configuration menu
    Copy the full SHA
    72013ef View commit details
    Browse the repository at this point in the history

  4. Address in-house review

    @erlend-aasland
    erlend-aasland committed May 25, 2022
    Configuration menu
    Copy the full SHA
    3c70d52 View commit details
    Browse the repository at this point in the history

  5. Recipes, take 1

    @erlend-aasland
    erlend-aasland committed May 25, 2022
    Configuration menu
    Copy the full SHA
    681baad View commit details
    Browse the repository at this point in the history

  6. Docstring wording

    @erlend-aasland
    erlend-aasland committed May 25, 2022
    Configuration menu
    Copy the full SHA
    bf4cb1f View commit details
    Browse the repository at this point in the history

Commits on Jun 22, 2022

  1. Update Doc/library/sqlite3.rst 

    Co-authored-by: CAM Gerlach <CAM.Gerlach@Gerlach.CAM>
    @CAM-Gerlach
    Erlend Egeberg Aasland and CAM-Gerlach authored Jun 22, 2022
    Configuration menu
    Copy the full SHA
    2d1a0c1 View commit details
    Browse the repository at this point in the history

  2. Update Doc/library/sqlite3.rst 

    Co-authored-by: CAM Gerlach <CAM.Gerlach@Gerlach.CAM>
    @CAM-Gerlach
    Erlend Egeberg Aasland and CAM-Gerlach authored Jun 22, 2022
    Configuration menu
    Copy the full SHA
    94308ff View commit details
    Browse the repository at this point in the history

  3. Update Doc/library/sqlite3.rst 

    Co-authored-by: CAM Gerlach <CAM.Gerlach@Gerlach.CAM>
    @CAM-Gerlach
    Erlend Egeberg Aasland and CAM-Gerlach authored Jun 22, 2022
    Configuration menu
    Copy the full SHA
    06657f2 View commit details
    Browse the repository at this point in the history

  4. Update Doc/library/sqlite3.rst 

    Co-authored-by: CAM Gerlach <CAM.Gerlach@Gerlach.CAM>
    @CAM-Gerlach
    Erlend Egeberg Aasland and CAM-Gerlach authored Jun 22, 2022
    Configuration menu
    Copy the full SHA
    b98e363 View commit details
    Browse the repository at this point in the history

  5. Update Doc/library/sqlite3.rst 

    Co-authored-by: CAM Gerlach <CAM.Gerlach@Gerlach.CAM>
    @CAM-Gerlach
    Erlend Egeberg Aasland and CAM-Gerlach authored Jun 22, 2022
    Configuration menu
    Copy the full SHA
    97812bb View commit details
    Browse the repository at this point in the history

  6. Update Doc/library/sqlite3.rst 

    Co-authored-by: CAM Gerlach <CAM.Gerlach@Gerlach.CAM>
    @CAM-Gerlach
    Erlend Egeberg Aasland and CAM-Gerlach authored Jun 22, 2022
    Configuration menu
    Copy the full SHA
    d3dd5a2 View commit details
    Browse the repository at this point in the history

  7. Update Doc/library/sqlite3.rst 

    Co-authored-by: CAM Gerlach <CAM.Gerlach@Gerlach.CAM>
    @CAM-Gerlach
    Erlend Egeberg Aasland and CAM-Gerlach authored Jun 22, 2022
    Configuration menu
    Copy the full SHA
    f381b65 View commit details
    Browse the repository at this point in the history

  8. Update Doc/library/sqlite3.rst 

    Co-authored-by: CAM Gerlach <CAM.Gerlach@Gerlach.CAM>
    @CAM-Gerlach
    Erlend Egeberg Aasland and CAM-Gerlach authored Jun 22, 2022
    Configuration menu
    Copy the full SHA
    65eb45c View commit details
    Browse the repository at this point in the history

  9. Update Doc/library/sqlite3.rst 

    Co-authored-by: CAM Gerlach <CAM.Gerlach@Gerlach.CAM>
    @CAM-Gerlach
    Erlend Egeberg Aasland and CAM-Gerlach authored Jun 22, 2022
    Configuration menu
    Copy the full SHA
    172c7d9 View commit details
    Browse the repository at this point in the history

  10. Update Doc/library/sqlite3.rst 

    Co-authored-by: CAM Gerlach <CAM.Gerlach@Gerlach.CAM>
    @CAM-Gerlach
    Erlend Egeberg Aasland and CAM-Gerlach authored Jun 22, 2022
    Configuration menu
    Copy the full SHA
    5ac2af9 View commit details
    Browse the repository at this point in the history

  11. Update Doc/library/sqlite3.rst 

    Co-authored-by: CAM Gerlach <CAM.Gerlach@Gerlach.CAM>
    @CAM-Gerlach
    Erlend Egeberg Aasland and CAM-Gerlach authored Jun 22, 2022
    Configuration menu
    Copy the full SHA
    433bf5a View commit details
    Browse the repository at this point in the history

  12. Update Doc/library/sqlite3.rst 

    Co-authored-by: CAM Gerlach <CAM.Gerlach@Gerlach.CAM>
    @CAM-Gerlach
    Erlend Egeberg Aasland and CAM-Gerlach authored Jun 22, 2022
    Configuration menu
    Copy the full SHA
    f7646de View commit details
    Browse the repository at this point in the history

  13. Assuming direct control 

    Co-authored-by: CAM Gerlach <CAM.Gerlach@Gerlach.CAM>
    @CAM-Gerlach
    Erlend Egeberg Aasland and CAM-Gerlach authored Jun 22, 2022
    Configuration menu
    Copy the full SHA
    6fbcff8 View commit details
    Browse the repository at this point in the history

Commits on Jun 23, 2022

  1. Address the last part of CAM's review

    @erlend-aasland
    erlend-aasland committed Jun 23, 2022
    Configuration menu
    Copy the full SHA
    b319b54 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into sqlite-doc-converters

    @erlend-aasland
    erlend-aasland committed Jun 23, 2022
    Configuration menu
    Copy the full SHA
    4e3b8fd View commit details
    Browse the repository at this point in the history

  3. Clarify parse column names further

    @erlend-aasland
    erlend-aasland committed Jun 23, 2022
    Configuration menu
    Copy the full SHA
    e821a7e View commit details
    Browse the repository at this point in the history

  4. Revert unneeded change

    @erlend-aasland
    erlend-aasland committed Jun 23, 2022
    Configuration menu
    Copy the full SHA
    bc295d8 View commit details
    Browse the repository at this point in the history

  5. Further clarify register_converter

    @erlend-aasland
    erlend-aasland committed Jun 23, 2022
    Configuration menu
    Copy the full SHA
    9235f8d View commit details
    Browse the repository at this point in the history

  6. Use testsetup/doctest

    @erlend-aasland
    erlend-aasland committed Jun 23, 2022
    Configuration menu
    Copy the full SHA
    8484164 View commit details
    Browse the repository at this point in the history

  7. Revert "Use testsetup/doctest" 

    This reverts commit 8484164.
    @erlend-aasland
    erlend-aasland committed Jun 23, 2022
    Configuration menu
    Copy the full SHA
    b579f67 View commit details
    Browse the repository at this point in the history

Commits on Jun 24, 2022

  1. Update Doc/library/sqlite3.rst 

    Co-authored-by: CAM Gerlach <CAM.Gerlach@Gerlach.CAM>
    @CAM-Gerlach
    Erlend Egeberg Aasland and CAM-Gerlach authored Jun 24, 2022
    Configuration menu
    Copy the full SHA
    0e42fa6 View commit details
    Browse the repository at this point in the history

Commits on Jun 25, 2022

  1. Reflow

    @erlend-aasland
    erlend-aasland committed Jun 25, 2022
    Configuration menu
    Copy the full SHA
    8d97fcb View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'upstream/main' into sqlite-doc-converters

    @erlend-aasland
    erlend-aasland committed Jun 25, 2022
    Configuration menu
    Copy the full SHA
    d300b33 View commit details
    Browse the repository at this point in the history