Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in Lib/idlelib/idle_test/test_parenmatch.py unit test #93332

Merged
merged 2 commits into from
May 30, 2022

Conversation

luzpaz
Copy link
Contributor

@luzpaz luzpaz commented May 29, 2022

No description provided.

@luzpaz luzpaz requested a review from terryjreedy as a code owner May 29, 2022 11:32
@cpython-cla-bot
Copy link

cpython-cla-bot bot commented May 29, 2022

All commit authors signed the Contributor License Agreement.
CLA signed

Copy link
Member

@terryjreedy terryjreedy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With my changes.

@terryjreedy
Copy link
Member

Thank you for the PR. I have seen the misspelling but left it because it "doesn't matter", except it does if I want others to carefully read idlelib files, which I do. The docstrings was also unclear.

@terryjreedy terryjreedy merged commit 4f195f9 into python:main May 30, 2022
@miss-islington
Copy link
Contributor

Thanks @luzpaz for the PR, and @terryjreedy for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11.
🐍🍒⛏🤖

@bedevere-bot
Copy link

GH-93339 is a backport of this pull request to the 3.11 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label May 30, 2022
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 30, 2022
Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
(cherry picked from commit 4f195f9)

Co-authored-by: luzpaz <luzpaz@users.noreply.github.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 30, 2022
Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
(cherry picked from commit 4f195f9)

Co-authored-by: luzpaz <luzpaz@users.noreply.github.com>
@bedevere-bot bedevere-bot removed the needs backport to 3.10 only security fixes label May 30, 2022
@bedevere-bot
Copy link

GH-93340 is a backport of this pull request to the 3.10 branch.

terryjreedy pushed a commit that referenced this pull request May 30, 2022
Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
(cherry picked from commit 4f195f9)

Co-authored-by: luzpaz <luzpaz@users.noreply.github.com>
terryjreedy pushed a commit that referenced this pull request May 30, 2022
Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
(cherry picked from commit 4f195f9)

Co-authored-by: luzpaz <luzpaz@users.noreply.github.com>
@luzpaz luzpaz deleted the typo/test_parenmatch branch May 30, 2022 03:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip issue skip news tests Tests in the Lib/test dir
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants