Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-93418: Fix an assert when an f-string expression is followed by an '=', but no closing brace. #93419

Merged
merged 1 commit into from
Jun 1, 2022
Merged

gh-93418: Fix an assert when an f-string expression is followed by an '=', but no closing brace. #93419

merged 1 commit into from
Jun 1, 2022

Conversation

ericvsmith
Copy link
Member

No description provided.

pablogsal
pablogsal approved these changes Jun 1, 2022
View reviewed changes
Copy link
Member

@pablogsal pablogsal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ericvsmith ericvsmith added needs backport to 3.10 only security fixes needs backport to 3.11 only security fixes labels Jun 1, 2022
@ericvsmith ericvsmith merged commit ee70c70 into python:main Jun 1, 2022
@miss-islington
Copy link
Contributor

Thanks @ericvsmith for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11.
🐍🍒⛏🤖

@ericvsmith ericvsmith deleted the issue93418 branch June 1, 2022 23:20
@ericvsmith
Copy link
Member Author

Closes #93418.

@ericvsmith ericvsmith mentioned this pull request Jun 1, 2022
Closed
@JelleZijlstra JelleZijlstra added needs backport to 3.10 only security fixes needs backport to 3.11 only security fixes and removed needs backport to 3.10 only security fixes needs backport to 3.11 only security fixes labels Jun 2, 2022
@miss-islington
Copy link
Contributor

Thanks @ericvsmith for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Thanks @ericvsmith for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 2, 2022
@ericvsmith @miss-islington
pythongh-93418: Fix an assert when an f-string expression is followed…
5edd048 
… by an '=', but no closing brace. (pythongh-93419)

(cherry picked from commit ee70c70)

Co-authored-by: Eric V. Smith <ericvsmith@users.noreply.github.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 2, 2022
@ericvsmith @miss-islington
pythongh-93418: Fix an assert when an f-string expression is followed…
d0afba9 
… by an '=', but no closing brace. (pythongh-93419)

(cherry picked from commit ee70c70)

Co-authored-by: Eric V. Smith <ericvsmith@users.noreply.github.com>
ericvsmith added a commit that referenced this pull request Jun 2, 2022
@miss-islington @ericvsmith
gh-93418: Fix an assert when an f-string expression is followed by an…
376d537 
… '=', but no closing brace. (gh-93419) (gh-93422)

(cherry picked from commit ee70c70)

Co-authored-by: Eric V. Smith <ericvsmith@users.noreply.github.com>

Co-authored-by: Eric V. Smith <ericvsmith@users.noreply.github.com>
ericvsmith added a commit that referenced this pull request Jun 2, 2022
@miss-islington @ericvsmith
gh-93418: Fix an assert when an f-string expression is followed by an…
855be47 
… '=', but no closing brace. (gh-93419) (gh-93423)

(cherry picked from commit ee70c70)

Co-authored-by: Eric V. Smith <ericvsmith@users.noreply.github.com>

Co-authored-by: Eric V. Smith <ericvsmith@users.noreply.github.com>
@hauntsaninja hauntsaninja removed needs backport to 3.10 only security fixes needs backport to 3.11 only security fixes labels Mar 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pablogsal pablogsal pablogsal approved these changes

@lysnikolaou lysnikolaou Awaiting requested review from lysnikolaou lysnikolaou is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@ericvsmith @miss-islington @pablogsal @JelleZijlstra @hauntsaninja @bedevere-bot