Add ABI dump to .gitignore #94166
Closed
Add ABI dump to .gitignore #94166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The ABI is only checked in maintenance branches, but it is sometimes useful to generate it for main. - The resulting file should be ignored in main. - The file should be created if it doesn't exist.
Calling
|
|
Yes, but AFAIK there are then warnings when you update a file that's ignored but tracked anyway. |
@encukou do you want me to add this change to that PR? |
|
Go ahead! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ABI is only checked in maintenance branches, but it is sometimes useful to generate it for main.
If this goes in, some “make maintenance branch” RM checklist/script will need a “remove
Doc/data/python*.abifrom.gitignore” entry.@pablogsal, this could be combined with #94135