Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-93096: Remove python -m base64 -t #94230

Merged
merged 8 commits into from
Jul 2, 2022
Merged

gh-93096: Remove python -m base64 -t #94230

merged 8 commits into from
Jul 2, 2022

Conversation

arhadthedev
Copy link
Member

@arhadthedev arhadthedev commented Jun 24, 2022 •
edited
Loading

test_base64.LegacyBase64TestCase.test_encodebytes/test_decodebytes is a more advanced version of the removed CLI argument.

The removed feature brings no benefit to an end user (unlike the rest of python -m base64).

@arhadthedev arhadthedev mentioned this pull request Jun 24, 2022
Open
27 tasks
corona10
corona10 requested changes Jul 2, 2022
View reviewed changes
@bedevere-bot
Copy link

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

corona10
corona10 reviewed Jul 2, 2022
View reviewed changes
Lib/base64.py Outdated
@@ -570,8 +570,7 @@ def main():
usage = """usage: %s [-h|-d|-e|-u|-t] [file|-]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: Can we update usage to use f-string?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done. Should I go further and convert it to argparse?

@arhadthedev
Copy link
Member Author

I have made the requested changes; please review again.

@bedevere-bot
Copy link

Thanks for making the requested changes!

@corona10: please review the changes made to this pull request.

@bedevere-bot bedevere-bot requested a review from corona10 July 2, 2022 06:45
corona10
corona10 approved these changes Jul 2, 2022
View reviewed changes
Copy link
Member

@corona10 corona10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@corona10 corona10 merged commit 7db1d2e into python:main Jul 2, 2022
@arhadthedev arhadthedev deleted the remove-base64-cli branch July 2, 2022 06:58
This was referenced Mar 6, 2023
Closed
Merged
@arhadthedev arhadthedev mentioned this pull request Apr 2, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@corona10 corona10 corona10 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@arhadthedev @bedevere-bot @corona10