Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-94485: Set line number of module's RESUME instruction to 0, as specified by PEP 626. #94498

Closed
wants to merge 6 commits into from
Closed

gh-94485: Set line number of module's RESUME instruction to 0, as specified by PEP 626. #94498

wants to merge 6 commits into from
+914 −417

Conversation

iritkatriel
Copy link
Member

@iritkatriel iritkatriel commented Jul 1, 2022 •
edited by bedevere-bot
Loading

@iritkatriel iritkatriel requested a review from markshannon as a code owner July 1, 2022 17:23
@iritkatriel iritkatriel marked this pull request as draft July 1, 2022 17:26
@iritkatriel iritkatriel marked this pull request as ready for review July 1, 2022 19:02
@iritkatriel iritkatriel requested a review from pablogsal July 4, 2022 22:56
@pablogsal
Copy link
Member

pablogsal commented Jul 4, 2022 •
edited
Loading

@iritkatriel I think you need to regenerate test_frozenmain.c (make regen-all).

iritkatriel added a commit to iritkatriel/cpython that referenced this pull request Jul 4, 2022
@iritkatriel
Merge remote-tracking branch 'upstream/main' into pythongh-94498
8a434f8
@iritkatriel iritkatriel closed this Jul 4, 2022
@iritkatriel
Copy link
Member Author

It's too messy when I try to work on Mark's branch. I'll create a new PR.

@markshannon markshannon deleted the module-resume-lineno-0 branch September 26, 2023 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arhadthedev arhadthedev arhadthedev left review comments

@markshannon markshannon Awaiting requested review from markshannon markshannon is a code owner

@pablogsal pablogsal Awaiting requested review from pablogsal

@terryjreedy terryjreedy Awaiting requested review from terryjreedy terryjreedy is a code owner

@berkerpeksag berkerpeksag Awaiting requested review from berkerpeksag berkerpeksag is a code owner

@erlend-aasland erlend-aasland Awaiting requested review from erlend-aasland erlend-aasland is a code owner

@vsajip vsajip Awaiting requested review from vsajip vsajip is a code owner

Assignees
No one assigned
Labels
awaiting core review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

frame.f_lineno can be None
5 participants
@iritkatriel @pablogsal @arhadthedev @bedevere-bot @markshannon