Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-84753: Clarify change made to inspect functions #94554

Merged
merged 1 commit into from
Jul 5, 2022
Merged

gh-84753: Clarify change made to inspect functions #94554

merged 1 commit into from
Jul 5, 2022

Conversation

ambv
Copy link
Contributor

@ambv ambv commented Jul 5, 2022 •
edited by bedevere-bot
Loading

The wording used in GH-94050 suggests narrower scope than what was actually implemented. This commit clarifies the full impact of GH-94050 in the change log.

New wording:
Screen Shot 2022-07-05 at 11 03 02

@ambv
pythongh-84753: Clarify change made to inspect functions
18695d7 
The wording used in pythonGH-94050 suggests narrower scope than what was actually
implemented. This commit clarifies the full impact of pythonGH-94050 in the change
log.
@ambv ambv added needs backport to 3.10 only security fixes needs backport to 3.11 only security fixes labels Jul 5, 2022
@pablogsal pablogsal merged commit a2a3f2c into python:main Jul 5, 2022
@miss-islington
Copy link
Contributor

Thanks @ambv for the PR, and @pablogsal for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Sorry @ambv and @pablogsal, I had trouble checking out the 3.11 backport branch.
Please backport using cherry_picker on command line.
cherry_picker a2a3f2c541290fc8f0720d1abdc12d564b856c28 3.11

@bedevere-bot
Copy link

GH-94559 is a backport of this pull request to the 3.10 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.10 only security fixes label Jul 5, 2022
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 5, 2022
@ambv @miss-islington
pythongh-84753: Clarify change made to inspect functions (pythonGH-…
d1deb60 
…94554)

(cherry picked from commit a2a3f2c)

Co-authored-by: Łukasz Langa <lukasz@langa.pl>
@ambv ambv deleted the gh-84753 branch July 5, 2022 12:23
@ambv ambv removed the needs backport to 3.11 only security fixes label Jul 5, 2022
ambv added a commit that referenced this pull request Jul 5, 2022
@miss-islington @ambv
gh-84753: Clarify change made to inspect functions (GH-94554) (GH-9…
3472f3b 
…4559)

(cherry picked from commit a2a3f2c)

Co-authored-by: Łukasz Langa <lukasz@langa.pl>
@ambv ambv added the needs backport to 3.11 only security fixes label Jul 5, 2022
@miss-islington
Copy link
Contributor

Thanks @ambv for the PR, and @pablogsal for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

@bedevere-bot
Copy link

GH-94560 is a backport of this pull request to the 3.11 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Jul 5, 2022
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 5, 2022
@ambv @miss-islington
pythongh-84753: Clarify change made to inspect functions (pythonGH-…
44160bd 
…94554)

(cherry picked from commit a2a3f2c)

Co-authored-by: Łukasz Langa <lukasz@langa.pl>
ambv added a commit that referenced this pull request Jul 5, 2022
@miss-islington @ambv
gh-84753: Clarify change made to inspect functions (GH-94554) (GH-9…
0615e7f 
…4560)

(cherry picked from commit a2a3f2c)

Co-authored-by: Łukasz Langa <lukasz@langa.pl>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pablogsal pablogsal pablogsal approved these changes

@kumaraditya303 kumaraditya303 kumaraditya303 approved these changes

Assignees

@pablogsal pablogsal

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ambv @miss-islington @bedevere-bot @pablogsal @kumaraditya303