Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-92546: Move pprint benchmark into pyperformance #94613

Merged
merged 4 commits into from
Jul 25, 2022
Merged

gh-92546: Move pprint benchmark into pyperformance #94613

merged 4 commits into from
Jul 25, 2022

Conversation

arhadthedev
Copy link
Member

@arhadthedev arhadthedev commented Jul 6, 2022 •
edited by miss-islington
Loading

This PR couples with python/pyperformance#222 and supersedes #92560. Inspired by #93096 (comment).

Automerge-Triggered-By: GH:ericsnowcurrently

@arhadthedev arhadthedev mentioned this pull request Jul 6, 2022
Closed
This was referenced Jul 6, 2022
Merged
Open
@kj7rrv kj7rrv mentioned this pull request Jul 6, 2022
Closed
hauntsaninja
hauntsaninja approved these changes Jul 8, 2022
View reviewed changes
Copy link
Contributor

@hauntsaninja hauntsaninja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Had a nit, but looks good!

@arhadthedev @hauntsaninja
Address Shantanu's review
f7bc339 
Co-authored-by: Shantanu <12621235+hauntsaninja@users.noreply.github.com>
@arhadthedev arhadthedev closed this Jul 8, 2022
@arhadthedev arhadthedev reopened this Jul 8, 2022
@arhadthedev
Copy link
Member Author

Restart tests because test.test_ssl.SimpleBackgroundTests.test_get_server_certificate_timeout timeout failure seems unrelated.

@arhadthedev
Copy link
Member Author

@ericsnowcurrently Could you look at this PR please? It removes the code fetched by python/pyperformance#222.

ericsnowcurrently
ericsnowcurrently approved these changes Jul 25, 2022
View reviewed changes
Copy link
Member

@ericsnowcurrently ericsnowcurrently left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, aside from one small change.

@miss-islington
Copy link
Contributor

Status check is done, and it's a success ✅ .

@miss-islington miss-islington merged commit c514094 into python:main Jul 25, 2022
@arhadthedev arhadthedev deleted the move-pprint-benchmark branch July 25, 2022 18:32
@ericsnowcurrently
Copy link
Member

Thanks for working on this, @arhadthedev!

@denballakh denballakh mentioned this pull request Oct 5, 2022
Closed
@donBarbos donBarbos mentioned this pull request Mar 12, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericsnowcurrently ericsnowcurrently ericsnowcurrently approved these changes

@hauntsaninja hauntsaninja hauntsaninja approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@arhadthedev @miss-islington @ericsnowcurrently @hauntsaninja @bedevere-bot