Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-94619: Remove long deprecated methods module_repr() and load_module() #94624

Merged
merged 2 commits into from
Aug 5, 2022
Merged

gh-94619: Remove long deprecated methods module_repr() and load_module() #94624

merged 2 commits into from
Aug 5, 2022

Conversation

warsaw
Copy link
Member

@warsaw warsaw commented Jul 6, 2022 •
edited by bedevere-bot
Loading

@warsaw warsaw added stdlib Python modules in the Lib dir topic-importlib 3.12 only security fixes labels Jul 6, 2022
@brettcannon brettcannon self-requested a review July 22, 2022 23:06
@warsaw
Copy link
Member Author

warsaw commented Jul 28, 2022

@brettcannon ping

@bedevere-bot
Copy link

When you're done making the requested changes, leave the comment: I have made the requested changes; please review again.

@warsaw @brettcannon
Update Misc/NEWS.d/next/Library/2022-07-06-14-57-33.gh-issue-94619.PR…
9a41d6a 
…qKVX.rst


Fix typo

Co-authored-by: Brett Cannon <brett@python.org>
@warsaw
Copy link
Member Author

warsaw commented Jul 30, 2022

I have made the requested changes; please review again.

@bedevere-bot
Copy link

Thanks for making the requested changes!

@brettcannon: please review the changes made to this pull request.

@bedevere-bot bedevere-bot requested a review from brettcannon July 30, 2022 19:50
@warsaw
Copy link
Member Author

warsaw commented Aug 3, 2022

@brettcannon re-ping!

@warsaw warsaw merged commit e1182bc into python:main Aug 5, 2022
@warsaw warsaw deleted the issue-94619 branch August 5, 2022 00:25
iritkatriel pushed a commit to iritkatriel/cpython that referenced this pull request Aug 11, 2022
@warsaw @brettcannon @iritkatriel
pythongh-94619: Remove long deprecated methods module_repr() and load…
befe5a5 
…_module() (python#94624)

* pythongh-94619: Remove long deprecated methods module_repr() and load_module()

Closes python#94619

* Update Misc/NEWS.d/next/Library/2022-07-06-14-57-33.gh-issue-94619.PRqKVX.rst

Fix typo

Co-authored-by: Brett Cannon <brett@python.org>

Co-authored-by: Brett Cannon <brett@python.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brettcannon brettcannon brettcannon approved these changes

Assignees
No one assigned
Labels
3.12 only security fixes stdlib Python modules in the Lib dir topic-importlib
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove previously deprecated importlib functions
3 participants
@warsaw @bedevere-bot @brettcannon