gh-94215: Fix error handling for line-tracing events #94681
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brandtbucher
added
interpreter-core
brandtbucher
added
the
🔨 test-with-buildbots
|
🤖 New build scheduled with the buildbot fleet by @brandtbucher for commit d616b11 🤖 If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again. |
bedevere-bot
removed
the
🔨 test-with-buildbots
tiran
approved these changes
Jul 8, 2022
iritkatriel
approved these changes
Jul 8, 2022
|
Worker |
|
Thanks @brandtbucher for the PR, and @tiran for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11. |
|
Sorry @brandtbucher and @tiran, I had trouble checking out the |
tiran
pushed a commit
to tiran/cpython
that referenced
this pull request
Jul 8, 2022
…thonGH-94681) * Re-enable crasher * Fix error handling for line-tracing events * blurb add (cherry picked from commit 23ee4a8) Co-authored-by: Brandt Bucher <brandtbucher@microsoft.com>
|
GH-94688 is a backport of this pull request to the 3.11 branch. |
tiran
added a commit
that referenced
this pull request
Jul 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supersedes #94659. This properly restores frame state following an exception raised by a line-tracing event. It also adds some comments to clarify the (somewhat subtle) nearby code.