Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[3.11] GH-93252: Fix error handling for failed Python calls (GH-94693) #94707

Closed
wants to merge 2 commits into from
Closed

[3.11] GH-93252: Fix error handling for failed Python calls (GH-94693) #94707

wants to merge 2 commits into from

Conversation

tiran
Copy link
Member

@tiran tiran commented Jul 9, 2022 •
edited by bedevere-bot
Loading

@tiran tiran requested a review from markshannon as a code owner July 9, 2022 11:33
@bedevere-bot bedevere-bot added type-crash A hard crash of the interpreter, possibly with a core dump awaiting core review labels Jul 9, 2022
@tiran tiran requested a review from brandtbucher July 9, 2022 11:33
@tiran
Copy link
Member Author

tiran commented Jul 9, 2022

I have removed the failing assert. 3.11 does not have co_framesize. GH-93908 was not backported to 3.11.

@tiran tiran mentioned this pull request Jul 9, 2022
Closed
@kumaraditya303
Copy link
Contributor

I have removed the failing assert. 3.11 does not have co_framesize. GH-93908 was not backported to 3.11.

Looks like we both created backport at the same time. #94708 has correct assert for 3.11.

@tiran
Copy link
Member Author

tiran commented Jul 9, 2022

Let's use your backport.

@tiran tiran closed this Jul 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markshannon markshannon Awaiting requested review from markshannon markshannon is a code owner

@brandtbucher brandtbucher Awaiting requested review from brandtbucher

Assignees
No one assigned
Labels
awaiting core review type-crash A hard crash of the interpreter, possibly with a core dump
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tiran @kumaraditya303 @bedevere-bot @brandtbucher