Skip to content

Conversation

@tiran
Copy link
Member

@tiran tiran commented Jul 12, 2022

  • fixed issue linker flags, LIBS is not passed to BLDSHARED
  • include version and git commit in output
  • include "Includes" directory, headers now have inline functions

- fixed issue linker flags, LIBS is not passed to BLDSHARED
- include version and git commit in output
- include "Includes" directory, headers now have inline functions
@tiran tiran added build The build process and cross-build needs backport to 3.11 only security fixes labels Jul 12, 2022
@tiran tiran requested a review from gpshead July 12, 2022 21:56
Copy link
Contributor

@mdboom mdboom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tried this and it works for me locally (Debian bookworm WSL)

@tiran tiran changed the title gh-94759: Create LCOV report with branch coverage gh-94759: Create LCOV report with branch coverage (GH-94793) Jul 13, 2022
@tiran tiran merged commit f5c02af into python:main Jul 13, 2022
@tiran tiran deleted the lcov-branch branch July 13, 2022 14:35
@miss-islington
Copy link
Contributor

Thanks @tiran for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 13, 2022
(cherry picked from commit f5c02af)

Co-authored-by: Christian Heimes <christian@python.org>
@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Jul 13, 2022
@bedevere-bot
Copy link

GH-94804 is a backport of this pull request to the 3.11 branch.

miss-islington added a commit that referenced this pull request Jul 13, 2022
(cherry picked from commit f5c02af)

Co-authored-by: Christian Heimes <christian@python.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

build The build process and cross-build skip news

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants