Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[3.11] gh-72889: Remove redundant mock.Mock()._is_coroutine = False workarounds (GH-94926) #94934

Merged
merged 1 commit into from
Jul 17, 2022
Merged

[3.11] gh-72889: Remove redundant mock.Mock()._is_coroutine = False workarounds (GH-94926) #94934

merged 1 commit into from
Jul 17, 2022

Conversation

miss-islington
Copy link
Contributor

@miss-islington miss-islington commented Jul 17, 2022 •
edited by bedevere-bot
Loading

(cherry picked from commit 07aeb74)

Co-authored-by: Thomas Grainger tagrain@gmail.com

@graingert @miss-islington
pythongh-72889: Remove redundant mock.Mock()._is_coroutine = False wo…
ed2722b 
…rkarounds (pythonGH-94926)

(cherry picked from commit 07aeb74)

Co-authored-by: Thomas Grainger <tagrain@gmail.com>
@miss-islington
Copy link
Contributor Author

Status check is done, and it's a success ✅ .

@bedevere-bot bedevere-bot mentioned this pull request Jul 17, 2022
Merged
gvanrossum
gvanrossum approved these changes Jul 17, 2022
View reviewed changes
Copy link
Member

@gvanrossum gvanrossum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming tests pass this is fine to land.

@miss-islington
Copy link
Contributor Author

Status check is done, and it's a success ✅ .

@miss-islington miss-islington merged commit 8d0249e into python:3.11 Jul 17, 2022
@miss-islington miss-islington deleted the backport-07aeb74-3.11 branch July 17, 2022 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gvanrossum gvanrossum gvanrossum approved these changes

@1st1 1st1 Awaiting requested review from 1st1 1st1 is a code owner

@asvetlov asvetlov Awaiting requested review from asvetlov asvetlov is a code owner

Assignees
No one assigned
Labels
skip news tests Tests in the Lib/test dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@miss-islington @gvanrossum @bedevere-bot @graingert