Skip to content

gh-95060: PyCode_Addr2Location return when addrq < 0 #95091

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 21, 2022
Merged

gh-95060: PyCode_Addr2Location return when addrq < 0 #95091

merged 2 commits into from
Jul 21, 2022

Conversation

Fidget-Spinner
Copy link
Member

@Fidget-Spinner Fidget-Spinner commented Jul 21, 2022 •
edited by bedevere-bot
Loading

@Fidget-Spinner Fidget-Spinner changed the title PyCode_Addr2Location return when addrq < 0 gh-95060: PyCode_Addr2Location return when addrq < 0 Jul 21, 2022
@Fidget-Spinner
Copy link
Member Author

Untested (?) code means all tests pass :)

@markshannon markshannon added the needs backport to 3.11 only security fixes label Jul 21, 2022
@markshannon
Copy link
Member

We should probably add some tests for this. But I don't think we need to do that for the backport.

@markshannon markshannon merged commit a6daaf2 into python:main Jul 21, 2022
@miss-islington
Copy link
Contributor

Thanks @Fidget-Spinner for the PR, and @markshannon for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

@bedevere-bot
Copy link

GH-95094 is a backport of this pull request to the 3.11 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 21, 2022
@Fidget-Spinner @miss-islington
Fix PyCode_Addr2Location when addrq < 0 (pythonGH-95091)
85b403f 
(cherry picked from commit a6daaf2)

Co-authored-by: Ken Jin <28750310+Fidget-Spinner@users.noreply.github.com>
@Fidget-Spinner Fidget-Spinner deleted the code_addr2location_assert branch July 21, 2022 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markshannon markshannon markshannon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Fidget-Spinner @markshannon @miss-islington @bedevere-bot