Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.11] gh-95132: Correctly relay *args and **kwds from sqlite3.connect to factory (GH-95146) #95158

Merged
merged 1 commit into from
Jul 23, 2022

Conversation

erlend-aasland
Copy link
Contributor

@erlend-aasland erlend-aasland commented Jul 23, 2022

This PR partially reverts gh-24421 (PR) and fixes the remaining concerns
given in gh-93044 (issue):

  • keyword arguments are passed as positional arguments to factory()
  • if an argument is not passed to sqlite3.connect(), its default value
    is passed to factory()

Co-authored-by: Serhiy Storchaka storchaka@gmail.com.
(cherry picked from commit a3d4d15)

Co-authored-by: Erlend Egeberg Aasland erlend.aasland@innova.no

…connect to factory (pythonGH-95146)

This PR partially reverts pythongh-24421 (PR) and fixes the remaining concerns
given in pythongh-93044 (issue):

- keyword arguments are passed as positional arguments to factory()
- if an argument is not passed to sqlite3.connect(), its default value
  is passed to factory()

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>.
(cherry picked from commit a3d4d15)

Co-authored-by: Erlend Egeberg Aasland <erlend.aasland@innova.no>
@erlend-aasland
Copy link
Contributor Author

erlend-aasland commented Jul 23, 2022

BTW, we should teach the cherry-picker to rerun clinic with -f.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants