-
-
Notifications
You must be signed in to change notification settings - Fork 31.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gh-94673: Add Per-Interpreter tp_weaklist for Static Builtin Types #95302
gh-94673: Add Per-Interpreter tp_weaklist for Static Builtin Types #95302
Conversation
ericsnowcurrently
commented
Jul 26, 2022
•
edited by bedevere-bot
Loading
edited by bedevere-bot
- Issue: [subinterpreters] Static types incorrectly share some objects between interpreters #94673
🤖 New build scheduled with the buildbot fleet by @ericsnowcurrently for commit f7d27fe 🤖 If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again. |
@ericsnowcurrently I expect that it won't make any difference, but I'm a bit concerned as It seems to me, that the extra check is not needed during de-allocation. |
Good point. I'll take a look Monday. |
Pyperformance shows 1.01x slower, so I'll need to address that. |
pythongh-95302 seems to have introduced a small performance regression. Here we make some minor changes to recover that lost performance.