gh-94673: Add Per-Interpreter tp_weaklist for Static Builtin Types #95302
+59
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
ericsnowcurrently
commented
Jul 26, 2022
•
ericsnowcurrently
commented
- Issue: [subinterpreters] Static types incorrectly share some objects between interpreters #94673
ericsnowcurrently
added
the
🔨 test-with-buildbots
|
🤖 New build scheduled with the buildbot fleet by @ericsnowcurrently for commit f7d27fe 🤖 If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again. |
bedevere-bot
removed
the
🔨 test-with-buildbots
|
@ericsnowcurrently I expect that it won't make any difference, but I'm a bit concerned as It seems to me, that the extra check is not needed during de-allocation. |
|
Good point. I'll take a look Monday. |
|
Pyperformance shows 1.01x slower, so I'll need to address that. |
ericsnowcurrently
added a commit
that referenced
this pull request
Aug 4, 2022
iritkatriel
pushed a commit
to iritkatriel/cpython
that referenced
this pull request
Aug 11, 2022
pythongh-95302 seems to have introduced a small performance regression. Here we make some minor changes to recover that lost performance.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.