Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-82180: Document support for non-integer arg removed from grp.getgrgid in 3.10 #95346

Merged
merged 1 commit into from
Aug 12, 2022
Merged

gh-82180: Document support for non-integer arg removed from grp.getgrgid in 3.10 #95346

merged 1 commit into from
Aug 12, 2022

Conversation

hugovk
Copy link
Member

@hugovk hugovk commented Jul 27, 2022 •
edited
Loading

Support for a non-integer argument like floats or strings in getgrgid was deprecated in Python 3.6:

This support was removed in Python 3.10:

But the docs were not updated to remove the deprecation warning:

Let's update to reflect the behaviour changed in Python 3.10.

@bedevere-bot bedevere-bot added awaiting review docs Documentation in the Doc dir skip news labels Jul 27, 2022
@hugovk hugovk added needs backport to 3.10 only security fixes needs backport to 3.11 only security fixes labels Jul 27, 2022
@ambv ambv changed the title gh-82180: Support for non-integer arg removed from grp.getgrgid in 3.10 gh-82180: Document support for non-integer arg removed from grp.getgrgid in 3.10 Aug 12, 2022
@ambv ambv merged commit 50bf5fa into python:main Aug 12, 2022
@miss-islington
Copy link
Contributor

Thanks @hugovk for the PR, and @ambv for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Aug 12, 2022
@hugovk @miss-islington
pythongh-82180: Document support for non-integer arg removed from grp…
80d9f95 
….getgrgid in 3.10 (pythonGH-95346)

(cherry picked from commit 50bf5fa)

Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Aug 12, 2022
@bedevere-bot
Copy link

GH-95929 is a backport of this pull request to the 3.11 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Aug 12, 2022
@hugovk @miss-islington
pythongh-82180: Document support for non-integer arg removed from grp…
c485c79 
….getgrgid in 3.10 (pythonGH-95346)

(cherry picked from commit 50bf5fa)

Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
@bedevere-bot bedevere-bot removed the needs backport to 3.10 only security fixes label Aug 12, 2022
@bedevere-bot
Copy link

GH-95930 is a backport of this pull request to the 3.10 branch.

ambv pushed a commit that referenced this pull request Aug 12, 2022
@miss-islington @hugovk
gh-82180: Document support for non-integer arg removed from grp.getgr…
7fdda1a 
…gid in 3.10 (GH-95346) (GH-95929)

(cherry picked from commit 50bf5fa)

Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
ambv pushed a commit that referenced this pull request Aug 12, 2022
@miss-islington @hugovk
gh-82180: Document support for non-integer arg removed from grp.getgr…
44bf05e 
…gid in 3.10 (GH-95346) (GH-95930)

(cherry picked from commit 50bf5fa)

Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
@hugovk hugovk deleted the gh-82180-update-docs branch August 14, 2022 06:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
docs Documentation in the Doc dir skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hugovk @miss-islington @bedevere-bot @ambv