Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH-95150: Use position and exception tables for code hashing and equality #95509

Merged
merged 5 commits into from
Aug 1, 2022
Merged

GH-95150: Use position and exception tables for code hashing and equality #95509

merged 5 commits into from
Aug 1, 2022

Conversation

brandtbucher
Copy link
Member

@brandtbucher brandtbucher commented Jul 31, 2022 •
edited by bedevere-bot
Loading

This requires relaxing a few tests, which are probably a bit too restrictive.

@brandtbucher brandtbucher added type-bug An unexpected behavior, bug, or error interpreter-core (Objects, Python, Grammar, and Parser dirs) needs backport to 3.11 only security fixes labels Jul 31, 2022
@brandtbucher brandtbucher requested a review from pablogsal July 31, 2022 20:51
@brandtbucher brandtbucher self-assigned this Jul 31, 2022
markshannon
markshannon approved these changes Aug 1, 2022
View reviewed changes
Copy link
Member

@markshannon markshannon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks for the fix.

@brandtbucher brandtbucher merged commit c7e5bba into python:main Aug 1, 2022
@miss-islington
Copy link
Contributor

Thanks @brandtbucher for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

@bedevere-bot
Copy link

GH-95541 is a backport of this pull request to the 3.11 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Aug 1, 2022
@brandtbucher @miss-islington
pythonGH-95150: Use position and exception tables for code hashing an…
192a1f6 
…d equality (pythonGH-95509)

(cherry picked from commit c7e5bba)

Co-authored-by: Brandt Bucher <brandtbucher@gmail.com>
miss-islington added a commit that referenced this pull request Aug 1, 2022
@miss-islington @brandtbucher
GH-95150: Use position and exception tables for code hashing and equa…
7baca3c 
…lity (GH-95509)

(cherry picked from commit c7e5bba)

Co-authored-by: Brandt Bucher <brandtbucher@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markshannon markshannon markshannon approved these changes

@pablogsal pablogsal Awaiting requested review from pablogsal

Assignees

@brandtbucher brandtbucher

Labels
interpreter-core (Objects, Python, Grammar, and Parser dirs) type-bug An unexpected behavior, bug, or error
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@brandtbucher @miss-islington @bedevere-bot @markshannon