Skip to content

gh-90110: Update the C Analyzer Tool Whitelists #95628

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 4, 2022
Merged

gh-90110: Update the C Analyzer Tool Whitelists #95628

merged 1 commit into from
Aug 4, 2022

Conversation

ericsnowcurrently
Copy link
Member

@ericsnowcurrently ericsnowcurrently commented Aug 3, 2022 •
edited by bedevere-bot
Loading

@corona10
Copy link
Member

corona10 commented Aug 4, 2022

Out of curiosity: How to verify the list?

@ericsnowcurrently
Copy link
Member Author

There are ways of getting the list of symbols (e.g. nm on linux), and a basic grep will also find most globals. Either could be used for comparison. In fact, I added c-analyzer.py data check early on with verification in mind. However, it wasn't a priority and I don't recall how far I got. I expect it doesn't work currently.

@ericsnowcurrently ericsnowcurrently merged commit 60f54d9 into python:main Aug 4, 2022
@ericsnowcurrently ericsnowcurrently deleted the fix-c-analyzer branch August 4, 2022 16:47
iritkatriel pushed a commit to iritkatriel/cpython that referenced this pull request Aug 11, 2022
@ericsnowcurrently @iritkatriel
pythongh-90110: Update the C Analyzer Tool Whitelists (pythongh-95628)
753a3ae
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ericsnowcurrently @corona10