Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-95731: Fix module docstring extraction in pygettext #95732

Merged
merged 5 commits into from
Oct 15, 2022
Merged

gh-95731: Fix module docstring extraction in pygettext #95732

merged 5 commits into from
Oct 15, 2022

Conversation

Jackenmen
Copy link
Contributor

@Jackenmen Jackenmen commented Aug 5, 2022 •
edited by bedevere-bot
Loading

@Jackenmen
Copy link
Contributor Author

I'm unsure whether it's supposed to be like this but the test run on GitHub Actions doesn't run tests in Lib/test_tools/test_i18n.py. The test run on Azure Pipelines PR includes it though so at least it passed those tests somewhere :)

@Jackenmen Jackenmen mentioned this pull request Aug 30, 2022
Closed
@JelleZijlstra JelleZijlstra self-assigned this Oct 7, 2022
@JelleZijlstra JelleZijlstra added needs backport to 3.10 only security fixes needs backport to 3.11 only security fixes labels Oct 12, 2022
@JelleZijlstra JelleZijlstra merged commit 120b4ab into python:main Oct 15, 2022
@miss-islington
Copy link
Contributor

Thanks @jack1142 for the PR, and @JelleZijlstra for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 15, 2022
@Jackenmen @miss-islington
pythongh-95731: Fix module docstring extraction in pygettext (pythonG…
e65454b 
…H-95732)

(cherry picked from commit 120b4ab)

Co-authored-by: Jakub Kuczys <me@jacken.men>
@bedevere-bot
Copy link

GH-98281 is a backport of this pull request to the 3.11 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Oct 15, 2022
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 15, 2022
@Jackenmen @miss-islington
pythongh-95731: Fix module docstring extraction in pygettext (pythonG…
ea1f64a 
…H-95732)

(cherry picked from commit 120b4ab)

Co-authored-by: Jakub Kuczys <me@jacken.men>
@bedevere-bot
Copy link

GH-98282 is a backport of this pull request to the 3.10 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.10 only security fixes label Oct 15, 2022
@Jackenmen Jackenmen deleted the fix_module_docstring_bug branch October 15, 2022 14:59
miss-islington added a commit that referenced this pull request Oct 15, 2022
@miss-islington @Jackenmen
gh-95731: Fix module docstring extraction in pygettext (GH-95732)
84a26e1 
(cherry picked from commit 120b4ab)

Co-authored-by: Jakub Kuczys <me@jacken.men>
JelleZijlstra pushed a commit that referenced this pull request Oct 16, 2022
@miss-islington @Jackenmen
[3.11] gh-95731: Fix module docstring extraction in pygettext (GH-95732…
b5874fa 
…) (#98281)

gh-95731: Fix module docstring extraction in pygettext (GH-95732)
(cherry picked from commit 120b4ab)

Co-authored-by: Jakub Kuczys <me@jacken.men>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JelleZijlstra JelleZijlstra JelleZijlstra left review comments

Assignees

@JelleZijlstra JelleZijlstra

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Jackenmen @miss-islington @bedevere-bot @JelleZijlstra