-
-
Notifications
You must be signed in to change notification settings - Fork 31.9k
gh-95271: Improve sqlite3 tutorial wording #95749
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gh-95271: Improve sqlite3 tutorial wording #95749
Conversation
I removed the |
Thanks for the initial review, Ezio! Tutorials are indeed hard :) PTAL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the delay; was busy with several other things.
A bunch of generally minor suggestions, and a couple somewhat bigger comments (in line with @ezio-melotti 's feedback)
Overall, the biggest thing I felt was missing aside from a few explanations was actually connecting the tutorial with at least a basic meaningful real-world goal. Creating a database isn't an end, its a means, and along the lines of what you said on the issue, the tutorial would be more helpful, and also more engaging and even "fun" if it has at least some Connection
to an actual use case.
Diataxis doesn't go into too much detail about this one way or the other, but a few passages relate:
A tutorial also needs to show the learner that they can be successful with the product - by having them do something both meaningful and attainable.
As long as the child managed to achieve something - however small - and enjoyed doing it, it will have laid down something in the construction of its technical expertise, that can be returned to and built upon next time.
it will have laid down something in the construction of its technical expertise, that can be returned to and built upon next time.
(Didn't meant to approve, meant to make that a comment sorry) |
I think we didn't quite know exactly what our destination was when we started, so we kept iterating and exploring different solutions until we were satisfied. Even though it was somewhat time-consuming, I don't think it was unneeded: as you mentioned, going through this whole process is what allowed us to learn. Had we just blindly followed some guidelines, we wouldn't have had the opportunity to try, compare, and discuss all our options and their pros and cons. After going through this experience (and after the Diataxis workshop), we will in a much better position to take informed decisions while working on the documentation, and we will be able to do so more efficiently. Also thank you for your patience and for listening to all our comments and bikesheddings1. Footnotes
|
+:100: That has definitely been my experience with Diataxis too—in general, I learn best by doing, and I've continually learned and re-learned new insights both in the overall course of experimenting with Diataxis, and just in this PR in particular. Funny enough, this seems to be one of the core messages of the Diataxis tutorial guidance itself:
Indeed, that seems to be how we've best learned Diataxis :)
Maybe, but it would have been difficult to actually see how these worked out in context before seeing the whole thing, and once we've gone through it once (or a few times), guidelines can be documented in the dev guide and future PRs will go much smoother, without any back and forth. We might have spent the time planning, and then thrown all that out anyway when it didn't quite work in practice, or at least wasn't fully informed by it. Typically, I'll write and have others review an outline (or more usually with Spyder, have whoever the writer is do that for me to review) for new docs, which can be very good at focusing discussion on the big picture—what needs to be included, what could be expended upon, what's missing and how to organize it all—before spending time on or getting too into the weeds of the details. Conversely, for re-writes like this, especially given its one of our first times grappling with applying Diataxis guidance to tutorials, it seems you did what planning you could, but we could only go so far before just going ahead with an implementation and iterating from there.
To be fair, that applies a lot more to me than to you, heh |
I think we should consider landing this. Further improvements can be done incrementally, using Issues and PRs. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @erlend-aasland ! Two last tiny clarifications.
Co-authored-by: C.A.M. Gerlach <CAM.Gerlach@Gerlach.CAM>
Co-authored-by: C.A.M. Gerlach <CAM.Gerlach@Gerlach.CAM>
This reverts commit 0e0398d.
All right, I'm going to land this tonight. Great working with you all! |
Thanks @erlend-aasland for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11. |
Co-authored-by: C.A.M. Gerlach <CAM.Gerlach@Gerlach.CAM> Co-authored-by: Ezio Melotti <ezio.melotti@gmail.com> (cherry picked from commit c87ea10) Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
GH-96082 is a backport of this pull request to the 3.11 branch. |
Co-authored-by: C.A.M. Gerlach <CAM.Gerlach@Gerlach.CAM> Co-authored-by: Ezio Melotti <ezio.melotti@gmail.com> (cherry picked from commit c87ea10) Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
GH-96083 is a backport of this pull request to the 3.10 branch. |
Using the Diátaxis language of tutorials as a guideline.