-
-
Notifications
You must be signed in to change notification settings - Fork 31.8k
gh-80480: Emit DeprecationWarning for array's 'u' type code #95760
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
As a user of the |
(I'm working my way through some PRs which have been approved and are labeled "awaiting merge", hence my seemingly bolt from the blue comment. Why? Read here.) Looks like this was approved before @asedeno's comment. Can someone respond to the expressed concern? (It seems no |
Thanks for the ping. I commented in the issue, let's continue there. |
Updated to target removal in 3.16, following addition of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I just left minor remarks on the doc. It's up to you to address them or ignore them ;-) Thanks for the updates.
The "u" type code for
array
was deprecated in Python 3.3 but only via documentation: https://docs.python.org/3.10/library/array.htmlLet's add the
DeprecationWarning
.It was originally planned to be removed in Python 4.0, but that was before we knew if 3.10 or 4.0 would come after 3.9:
#80480 (comment)
So as this is going into
3.123.13, let's target3.143.153.16 for removal.