Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-94808: Coverage: Test that maximum indentation level is handled #95926

Merged
merged 2 commits into from
Oct 6, 2022
Merged

gh-94808: Coverage: Test that maximum indentation level is handled #95926

merged 2 commits into from
Oct 6, 2022

Conversation

mdboom
Copy link
Contributor

@mdboom mdboom commented Aug 12, 2022 •
edited by bedevere-bot
Loading

@bedevere-bot bedevere-bot added tests Tests in the Lib/test dir awaiting review labels Aug 12, 2022
@iritkatriel
Copy link
Member

iritkatriel commented Aug 16, 2022 •
edited
Loading

What is the source file/function that this test is covering?

@mdboom
Copy link
Contributor Author

mdboom commented Aug 17, 2022

In tokenizer.c, in tok_get

@mdboom mdboom requested a review from brandtbucher August 29, 2022 19:56
serhiy-storchaka
serhiy-storchaka approved these changes Sep 10, 2022
View reviewed changes
Lib/test/test_tokenize.py Outdated
valid = generate_source(MAXINDENT - 1)
tokens = list(_generate_tokens_from_c_tokenizer(valid))
self.assertEqual(tokens[-1].type, DEDENT)
exec(valid)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would not compile() be enough?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea. Updated.

nanjekyejoannah
nanjekyejoannah approved these changes Oct 6, 2022
View reviewed changes
Copy link
Contributor

@nanjekyejoannah nanjekyejoannah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mdboom , seems you handled the requested review.

@nanjekyejoannah nanjekyejoannah merged commit 23e83a8 into python:main Oct 6, 2022
@miss-islington
Copy link
Contributor

Thanks @mdboom for the PR, and @nanjekyejoannah for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

@bedevere-bot
Copy link

GH-97979 is a backport of this pull request to the 3.11 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Oct 6, 2022
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 6, 2022
@mdboom @miss-islington
pythongh-94808: Coverage: Test that maximum indentation level is hand…
6074081 
…led (pythonGH-95926)

* pythongh-94808: Coverage: Test that maximum indentation level is handled

* Use "compile" rather than "exec"
(cherry picked from commit 23e83a8)

Co-authored-by: Michael Droettboom <mdboom@gmail.com>
@bedevere-bot
Copy link

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot ARM64 macOS 3.x has failed when building commit 23e83a8.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/725/builds/2739) and take a look at the build logs.
  4. Check if the failure is related to this commit (23e83a8) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/725/builds/2739

Summary of the results of the build (if available):

== Tests result: ENV CHANGED ==

410 tests OK.

10 slowest tests:

  • test_signal: 4 min 17 sec
  • test_concurrent_futures: 2 min 42 sec
  • test_multiprocessing_spawn: 2 min 3 sec
  • test_multiprocessing_forkserver: 1 min 35 sec
  • test_asyncio: 1 min 30 sec
  • test_logging: 1 min 12 sec
  • test_nntplib: 1 min 1 sec
  • test_capi: 44.4 sec
  • test_ssl: 42.8 sec
  • test_io: 38.2 sec

1 test altered the execution environment:
test_subprocess

23 tests skipped:
test_devpoll test_epoll test_gdb test_idle test_ioctl
test_launcher test_msilib test_multiprocessing_fork
test_ossaudiodev test_perf_profiler test_spwd test_startfile
test_tcl test_tix test_tkinter test_ttk test_ttk_textonly
test_turtle test_winconsoleio test_winreg test_winsound test_wmi
test_zipfile64

Total duration: 8 min 25 sec

Click to see traceback logs 
Traceback (most recent call last):
  File "/Users/buildbot/buildarea/3.x.pablogsal-macos-m1.macos-with-brew/build/Lib/threading.py", line 1049, in _bootstrap_inner
    self.run()
  File "/Users/buildbot/buildarea/3.x.pablogsal-macos-m1.macos-with-brew/build/Lib/threading.py", line 986, in run
    self._target(*self._args, **self._kwargs)
  File "/Users/buildbot/buildarea/3.x.pablogsal-macos-m1.macos-with-brew/build/Lib/test/test_subprocess.py", line 1348, in open_fds
    fds.extend(os.pipe())
               ^^^^^^^^^
OSError: [Errno 23] Too many open files in system
k

lysnikolaou pushed a commit to lysnikolaou/cpython that referenced this pull request Oct 6, 2022
@mdboom @lysnikolaou
pythongh-94808: Coverage: Test that maximum indentation level is hand…
b3b300e 
…led (python#95926)

* pythongh-94808: Coverage: Test that maximum indentation level is handled

* Use "compile" rather than "exec"
nanjekyejoannah pushed a commit that referenced this pull request Oct 6, 2022
@miss-islington @mdboom
[3.11] gh-94808: Coverage: Test that maximum indentation level is han…
1cd19f7 
…dled (GH-95926) (#97979)

gh-94808: Coverage: Test that maximum indentation level is handled (GH-95926)

* gh-94808: Coverage: Test that maximum indentation level is handled

* Use "compile" rather than "exec"
(cherry picked from commit 23e83a8)

Co-authored-by: Michael Droettboom <mdboom@gmail.com>

Co-authored-by: Michael Droettboom <mdboom@gmail.com>
carljm added a commit to carljm/cpython that referenced this pull request Oct 6, 2022
@carljm
Merge branch 'main' into dictwatch
e5d2169 
* main:
  fixes pythongh-96078: os.sched_yield release the GIL while calling sched_yield(2). (pythongh-97965)
  pythongh-65961: Do not rely solely on `__cached__` (pythonGH-97990)
  pythongh-97850: Remove the open issues section from the import reference (python#97935)
  Docs: pin sphinx-lint (pythonGH-97992)
  pythongh-94590: add signatures to operator itemgetter, attrgetter, methodcaller (python#94591)
  Add Pynche's move to the What's new in 3.11 (python#97974)
  pythongh-97781: Apply changes from importlib_metadata 5. (pythonGH-97785)
  pythongh-86482: Document assignment expression need for ()s (python#23291)
  pythongh-97943: PyFunction_GetAnnotations should return a borrowed reference. (python#97949)
  pythongh-94808: Coverage: Test that maximum indentation level is handled (python#95926)
carljm added a commit to carljm/cpython that referenced this pull request Oct 8, 2022
@carljm
Merge branch 'main' into typewatch
1af2a98 
* main: (53 commits)
  pythongh-94808: Coverage: Test that maximum indentation level is handled (python#95926)
  pythonGH-88050: fix race in closing subprocess pipe in asyncio  (python#97951)
  pythongh-93738: Disallow pre-v3 syntax in the C domain (python#97962)
  pythongh-95986: Fix the example using match keyword (python#95989)
  pythongh-97897: Prevent os.mkfifo and os.mknod segfaults with macOS 13 SDK (pythonGH-97944)
  pythongh-94808: Cover `PyUnicode_Count` in CAPI (python#96929)
  pythongh-94808: Cover `PyObject_PyBytes` case with custom `__bytes__` method (python#96610)
  pythongh-95691: Doc BufferedWriter and BufferedReader (python#95703)
  pythonGH-88968: Add notes about socket ownership transfers (python#97936)
  pythongh-96865: [Enum] fix Flag to use CONFORM boundary (pythonGH-97528)
  pythongh-65961: Raise `DeprecationWarning` when `__package__` differs from `__spec__.parent` (python#97879)
  docs(typing): add "see PEP 675" to LiteralString (python#97926)
  pythongh-97850: Remove all known instances of module_repr() (python#97876)
  I changed my surname early this year (python#96671)
  pythongh-93738: Documentation C syntax (:c:type:<C type> -> :c:expr:<C type>) (python#97768)
  pythongh-91539: improve performance of get_proxies_environment  (python#91566)
  build(deps): bump actions/stale from 5 to 6 (python#97701)
  pythonGH-95172 Make the same version `versionadded` oneline (python#95172)
  pythongh-88050: Fix asyncio subprocess to kill process cleanly when process is blocked (python#32073)
  pythongh-93738: Documentation C syntax (Function glob patterns -> literal markup) (python#97774)
  ...
mpage pushed a commit to mpage/cpython that referenced this pull request Oct 11, 2022
@mdboom @mpage
pythongh-94808: Coverage: Test that maximum indentation level is hand…
af96109 
…led (python#95926)

* pythongh-94808: Coverage: Test that maximum indentation level is handled

* Use "compile" rather than "exec"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nanjekyejoannah nanjekyejoannah nanjekyejoannah approved these changes

@brandtbucher brandtbucher Awaiting requested review from brandtbucher

@serhiy-storchaka serhiy-storchaka Awaiting requested review from serhiy-storchaka

Assignees
No one assigned
Labels
skip news tests Tests in the Lib/test dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@mdboom @iritkatriel @miss-islington @bedevere-bot @serhiy-storchaka @nanjekyejoannah