-
-
Notifications
You must be signed in to change notification settings - Fork 31.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gh-95914: Add Py_UNICODE encode APIs removed in PEP 624 to 3.11 What's New #96016
Conversation
Nope... The |
Right, which is why I don't understand why it doesn't work, unless this is a Spihnx bug or some corner case (which I searched for at some length in the Sphinx repo and googled, to no avail). I figure if anyone knows, @AA-Turner would...
Right, of course, but the whole reason I'm adding the |
@CAM-Gerlach Is this still a draft or can it be reviewed? |
I believe the markup for removed functions should be fixed before merging -- from |
I ended up going with the default-domain This should be ready for final review now @pablogsal |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Thanks @CAM-Gerlach for the PR, and @pablogsal for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11. |
… What's New (pythonGH-96016) * 3.11 Whatsnew: Add Py_UNICODE encode functions removed in PEP 624 * Just use :func: instead of :c:func: for non-resolved funcs so ! works (cherry picked from commit b6d88b7) Co-authored-by: C.A.M. Gerlach <CAM.Gerlach@Gerlach.CAM>
GH-96094 is a backport of this pull request to the 3.11 branch. |
Add a mention of the deprecated
Py_UNICODE
encode functions removed in Python 3.11 per PEP-624 by @methane in issue #88195 / PR #25881 to 3.11 What's New, as discussed in #95914 .Inada-san, could you take a look at this?
Also, @AA-Turner @ezio-melotti @hugovk , any idea why
!
appears to not be working as documented in:c:func:
here, resulting in-n
warnings and incorrect rendering? Does it have something to do with the legacy C role support still used by the CPython docs?