gh-96143: Add some comments and minor fixes missed in the original PR #96433
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pablogsal
changed the title
Co-authored-by: Kumar Aditya <59607654+kumaraditya303@users.noreply.github.com>
|
|
||
| size_t n_copies = mem_size / code_size; | ||
| for (size_t i = 0; i < n_copies; i++) { | ||
| memcpy(memory + i * code_size, start, code_size * sizeof(char)); | ||
| } | ||
| // Some systems may prevent us from creating executable code on the fly. | ||
| // TODO: Call icache invalidation intrinsics if available: | ||
| // __builtin___clear_cache/__clear_cache (depending if clang/gcc). This is |
There was a problem hiding this comment.
The kernel would clear the icache for us. Not sure if this would ever be a problem.
There was a problem hiding this comment.
That's not correct in the general case. You are supposed to call this in aarch64 if you modify the code in some executable segment after it was read at least once. This doesn't apply for us but is not true that in all systems the kernel will clear it for us
There was a problem hiding this comment.
See the discussion in the previous pr
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Automerge-Triggered-By: GH:pablogsal