Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-93963: Remove ResourceReaderDefaultsTests #96598

Merged
merged 1 commit into from
Sep 5, 2022
Merged

gh-93963: Remove ResourceReaderDefaultsTests #96598

merged 1 commit into from
Sep 5, 2022

Conversation

jaraco
Copy link
Member

@jaraco jaraco commented Sep 5, 2022 •
edited by miss-islington
Loading

@jaraco
bpo-93963: Remove ResourceReaderDefaultsTests. If these tests are imp…
30133e7 
…ortant, they should be implemented in importlib_resources.
@bedevere-bot bedevere-bot added awaiting core review tests Tests in the Lib/test dir labels Sep 5, 2022
@jaraco jaraco added the needs backport to 3.11 only security fixes label Sep 5, 2022
@jaraco jaraco changed the title bpo-93963: Remove ResourceReaderDefaultsTests gh-93963: Remove ResourceReaderDefaultsTests Sep 5, 2022
@jaraco jaraco mentioned this pull request Sep 5, 2022
Closed
5 tasks
@miss-islington miss-islington merged commit 52fe7e5 into python:main Sep 5, 2022
@miss-islington
Copy link
Contributor

Thanks @jaraco for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Sorry, @jaraco, I could not cleanly backport this to 3.11 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 52fe7e50c9945b7db60190b4b97e1213d05200b2 3.11

@miss-islington miss-islington self-assigned this Sep 5, 2022
@bedevere-bot
Copy link

GH-96602 is a backport of this pull request to the 3.11 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Sep 5, 2022
jaraco added a commit to jaraco/cpython that referenced this pull request Sep 5, 2022
@jaraco
[3.11] pythongh-93963: Remove ResourceReaderDefaultsTests (pythonGH-9…
04644c1 
…6598)

Automerge-Triggered-By: GH:jaraco.
(cherry picked from commit 52fe7e5)

Co-authored-by: Jason R. Coombs <jaraco@jaraco.com>
@jaraco jaraco deleted the bpo-93963/remove-resource-reader-defaults-tests branch September 5, 2022 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iritkatriel iritkatriel iritkatriel approved these changes

Assignees

@miss-islington miss-islington

Labels
skip news tests Tests in the Lib/test dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jaraco @miss-islington @bedevere-bot @iritkatriel