Skip to content

gh-90110: Fix the c-analyzer Tool #96731

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 26 commits into from
Sep 12, 2022
Merged

gh-90110: Fix the c-analyzer Tool #96731

merged 26 commits into from
Sep 12, 2022

Conversation

ericsnowcurrently
Copy link
Member

@ericsnowcurrently ericsnowcurrently commented Sep 10, 2022 •
edited by bedevere-bot
Loading

This includes:

  • update the whitelists
  • fixes so we can stop ignoring some of the files
  • ensure Include/cpython/*.h get analyzed

@ericsnowcurrently
Add large, ignored files to MAX_SIZES.
f93e2c6
@ericsnowcurrently
Fixups for Python/thread_pthread.h.
a8bd590
@ericsnowcurrently
Add some missing defines.
683d1ba
@ericsnowcurrently
Support passing "includes" to preprocess().
dd8b682
@ericsnowcurrently
Update parser data.
1b822b7
@ericsnowcurrently
Fix whitelists.
42114c0
@ericsnowcurrently
Stop ignoring cjkcodecs.
342ccee
@ericsnowcurrently
Stop ignoring _dbmmodule.c.
12fc111
@ericsnowcurrently
Stop ignoring stringlib.
1f82c05
@ericsnowcurrently
Add a TODO.
6e67f68
@ericsnowcurrently
Fix perf_trampoline.c.
5c898c4
@ericsnowcurrently
Stop ignoring hashlib.h.
b930efa
@ericsnowcurrently
Fix thread_pthread_stubs.h.
c74b308
@ericsnowcurrently
Stop ignoring KeccakP-1600-opt64.c.
7296153
@ericsnowcurrently
Add a note about maybe-inline-actual.
9566436
@ericsnowcurrently
Add c_common.fsutil.match_path_tail().
f91b6d7
@ericsnowcurrently
Do not add the current file as an include.
28d5cc5
@ericsnowcurrently
Update gcc.preprocess().
2fa3d87
@ericsnowcurrently
Always print the current filename when c_parser.parse_files() fails.
401bd73
@ericsnowcurrently
Use a consistent filename variable name.
fc3a5a5
@ericsnowcurrently
Always use absolute paths.
917a099
@ericsnowcurrently
Stop filtering includes.
13449a9
@ericsnowcurrently
Fix analysis for typeobject.c.
c7050eb
@ericsnowcurrently
Ignore pystate.c:initial.
07a87cb
@ericsnowcurrently
Fix "samefiles" handling.
d1d725e
kumaraditya303
kumaraditya303 approved these changes Sep 12, 2022
View reviewed changes
Copy link
Contributor

@kumaraditya303 kumaraditya303 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! The number of static globals are decreasing steadily.

@ericsnowcurrently ericsnowcurrently merged commit 1756ffd into python:main Sep 12, 2022
@ericsnowcurrently ericsnowcurrently deleted the fix-c-analyzer branch September 12, 2022 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chalggg chalggg chalggg left review comments

@kumaraditya303 kumaraditya303 kumaraditya303 approved these changes

Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ericsnowcurrently @chalggg @kumaraditya303 @bedevere-bot